Issue 128683002: Array constructor can be simplified by loading context from JSFunction.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 128683002: Array constructor can be simplified by loading context from JSFunction. (Closed)

Created:
6 years, 11 months ago by mvstanton

Modified:
6 years, 11 months ago

Reviewers:
Toon Verwaest

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Array constructor can be simplified by loading context from JSFunction. BUG= R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18518

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+50 lines, -100 lines)			Patch
M	src/arm/code-stubs-arm.cc	View	1	3 chunks	+2 lines, -6 lines	0 comments	Download
M	src/arm/lithium-codegen-arm.cc	View	1	2 chunks	+4 lines, -6 lines	0 comments	Download
M	src/code-stubs.h	View	1	7 chunks	+5 lines, -22 lines	0 comments	Download
M	src/code-stubs-hydrogen.cc	View		6 chunks	+3 lines, -31 lines	0 comments	Download
M	src/hydrogen.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/hydrogen.cc	View	1	2 chunks	+18 lines, -1 line	0 comments	Download
M	src/ia32/code-stubs-ia32.cc	View		3 chunks	+1 line, -4 lines	0 comments	Download
M	src/ia32/lithium-codegen-ia32.cc	View		2 chunks	+4 lines, -6 lines	0 comments	Download
M	src/mips/code-stubs-mips.cc	View	1	3 chunks	+2 lines, -6 lines	0 comments	Download
M	src/mips/lithium-codegen-mips.cc	View	1	2 chunks	+4 lines, -6 lines	0 comments	Download
M	src/x64/code-stubs-x64.cc	View	1	3 chunks	+2 lines, -6 lines	0 comments	Download
M	src/x64/lithium-codegen-x64.cc	View	1	2 chunks	+4 lines, -6 lines	0 comments	Download

Total messages: 3 (0 generated)

mvstanton

Hi Toon, here is the change we discussed (sans ports). I'm not that happy with ...

6 years, 11 months ago (2014-01-08 17:20:25 UTC) #1

mvstanton

6 years, 11 months ago (2014-01-09 15:07:35 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r18518 (presubmit successful).