net/base/net_error_list.h - Issue 1286793002: Treat failure to parse certificates as SSL protocol errors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/base/net_error_list.h

Issue 1286793002: Treat failure to parse certificates as SSL protocol errors. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/base/net_error_list.h

diff --git a/net/base/net_error_list.h b/net/base/net_error_list.h

index a57cd493da0c1dad582ef9ff25ca034e1679162a..502f5ac8b2bb983e1fbc2a1f4b115106cf96ab61 100644

--- a/net/base/net_error_list.h

+++ b/net/base/net_error_list.h

@@ -347,6 +347,11 @@ NET_ERROR(SSL_FALLBACK_BEYOND_MINIMUM_VERSION, -165)

// problem.

NET_ERROR(ICANN_NAME_COLLISION, -166)

+// The SSL server presented a certificate which could not be decoded. This is

+// not a certificate error code as now X509Certificate object is available. This

Ryan Sleevi 2015/08/11 23:25:25 'code as now' -> 'code, as no'

davidben 2015/08/12 21:40:02 Done.

+// error is fatal and may not be clicked though.

Ryan Sleevi 2015/08/11 23:25:25 'fatal and may not be clicked through' -> 'fatal,

davidben 2015/08/12 21:40:02 Done.

+NET_ERROR(SSL_SERVER_CERT_BAD_FORMAT, -167)

// Certificate error codes

// The values of certificate error codes must be consecutive.

« no previous file with comments | « chrome/common/localized_error.cc ('k') | net/socket/ssl_client_socket_nss.cc » ('j') | no next file with comments »