dart2js: fixes additional warnings from analyzer

pkg/compiler/lib/src/info/info.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /// Data collected by the dump-info task.
 library compiler.src.lib.info;
 
 // Note: this file intentionally doesn't import anything from the compiler. That
 // should make it easier for tools to depend on this library. The idea is that
 // by using this library, tools can consume the information in the same way it
@@ skipping 223 matching lines @@
         src.uses.add(new DependencyInfo(target, dep['mask']));
       }
     });
 
     result.program = parseProgram(json['program']);
     // todo: version, etc
     return result;
   }
 
   LibraryInfo parseLibrary(Map json) {
-    var result = parseId(json['id'])
-        ..name = json['name']
+    LibraryInfo result = parseId(json['id']);
+    result..name = json['name']
         ..uri = Uri.parse(json['canonicalUri'])
         ..outputUnit = parseId(json['outputUnit'])
         ..size = json['size'];
-    assert(result is LibraryInfo);
     for (var child in json['children'].map(parseId)) {
       if (child is FunctionInfo) {
         result.topLevelFunctions.add(child);
       } else if (child is FieldInfo) {
         result.topLevelVariables.add(child);
       } else if (child is ClassInfo) {
         result.classes.add(child);
       } else {
         assert(child is TypedefInfo);
         result.typedefs.add(child);
       }
     }
     return result;
   }
 
   ClassInfo parseClass(Map json) {
-    var result = parseId(json['id'])
-        ..name = json['name']
+    ClassInfo result = parseId(json['id']);
+    result..name = json['name']
         ..outputUnit = parseId(json['outputUnit'])
         ..size = json['size']
         ..isAbstract = json['modifiers']['abstract'] == true;
     assert(result is ClassInfo);
     for (var child in json['children'].map(parseId)) {
       if (child is FunctionInfo) {
         result.functions.add(child);
       } else {
         assert(child is FieldInfo);
         result.fields.add(child);
       }
     }
     return result;
   }
 
   FieldInfo parseField(Map json) {
-    return parseId(json['id'])
-      ..name = json['name']
+    FieldInfo result = parseId(json['id']);
+    return result..name = json['name']
       ..outputUnit = parseId(json['outputUnit'])
       ..size = json['size']
       ..type = json['type']
       ..inferredType = json['inferredType']
       ..code = json['code']
       ..closures = json['children'].map(parseId).toList();
   }
 
-  TypedefInfo parseTypedef(Map json) => parseId(json['id'])
-      ..name = json['name']
+  TypedefInfo parseTypedef(Map json) {
+    TypedefInfo result = parseId(json['id']);
+    return result..name = json['name']
       ..type = json['type']
       ..size = 0;
+  }
 
   ProgramInfo parseProgram(Map json) =>
       new ProgramInfo()..size = json['size'];
 
   FunctionInfo parseFunction(Map json) {
-    return parseId(json['id'])
-      ..name = json['name']
+    FunctionInfo result = parseId(json['id']);
+    return result..name = json['name']
       ..outputUnit = parseId(json['outputUnit'])
       ..size = json['size']
       ..type = json['type']
       ..returnType = json['returnType']
       ..inferredReturnType = json['inferredReturnType']
       ..parameters = json['parameters'].map(parseParameter).toList()
       ..code = json['code']
       ..sideEffects = json['sideEffects']
       ..modifiers = parseModifiers(json['modifiers'])
       ..closures = json['children'].map(parseId).toList();
@@ skipping 317 matching lines @@
     case InfoKind.library: return 'library';
     case InfoKind.clazz: return 'class';
     case InfoKind.function: return 'function';
     case InfoKind.field: return 'field';
     case InfoKind.outputUnit: return 'outputUnit';
     case InfoKind.typedef: return 'typedef';
     default: return null;
   }
 }
 
-int _idFromSerializedId(String serialiedId) =>
+int _idFromSerializedId(String serializedId) =>
     int.parse(serializedId.substring(serializedId.indexOf('/') + 1));
 
-String _kindFromSerializedId(String serializedId) =>
+InfoKind _kindFromSerializedId(String serializedId) =>
     _kindFromString(serializedId.substring(0, serializedId.indexOf('/')));
 
 InfoKind _kindFromString(String kind) {
   switch(kind) {
     case 'library': return InfoKind.library;
     case 'class': return InfoKind.clazz;
     case 'function': return InfoKind.function;
     case 'field': return InfoKind.field;
     case 'outputUnit': return InfoKind.outputUnit;
     case 'typedef': return InfoKind.typedef;
@@ skipping 39 matching lines @@
   }
 
   visitField(FieldInfo info) {
     info.closures.forEach(visitFunction);
   }
 
   visitFunction(FunctionInfo info) {
     info.closures.forEach(visitFunction);
   }
 }