Issue 128673002: [Mac] Hook up the "Remove" button in the collected cookies dialog.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 128673002: [Mac] Hook up the "Remove" button in the collected cookies dialog. (Closed)

Created:
6 years, 11 months ago by Robert Sesek

Modified:
6 years, 11 months ago

Reviewers:
Nico

CC:
chromium-reviews, markusheintz_

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Mac] Hook up the "Remove" button in the collected cookies dialog. This also resurrects the CookiesTreeModelObserverBridge (now called CookiesTreeControllerBridge) that I removed in r77477 along with the rest of the native preferences. The class is used to dynamically update the tree view in response to model changes. XIB changes: * Made the "Blocked" tab buttons use the constrained window style. * Matched the height of the NSOutlineView between the allowed and blocked tabs. BUG=168996 TEST=Go to google.com, click on the lock icon, click on "Show cookies", and remove site data from the Allowed pane. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243633

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+400 lines, -96 lines)			Patch
M	chrome/app/nibs/CollectedCookies.xib	View	28 chunks	+183 lines, -22 lines	0 comments	Download
M	chrome/browser/ui/cocoa/content_settings/collected_cookies_mac.h	View	4 chunks	+8 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/cocoa/content_settings/collected_cookies_mac.mm	View	11 chunks	+55 lines, -70 lines	0 comments	Download
A	chrome/browser/ui/cocoa/content_settings/cookies_tree_controller_bridge.h	View	1 chunk	+51 lines, -0 lines	0 comments	Download
A	chrome/browser/ui/cocoa/content_settings/cookies_tree_controller_bridge.mm	View	1 chunk	+101 lines, -0 lines	0 comments	Download
M	chrome/chrome_browser_ui.gypi	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsesek@chromium.org/128673002/1

6 years, 11 months ago (2014-01-08 17:49:33 UTC) #3

Message was sent while issue was closed.

Change committed as 243633

Expand Messages | Collapse Messages