Webapp changes to support asking for a PIN

remoting/webapp/client_plugin.js

Index: remoting/webapp/client_plugin.js
diff --git a/remoting/webapp/client_plugin.js b/remoting/webapp/client_plugin.js
index 068663150ec5e11bd619a6102a2d81bba3489e48..177078adc158de4a66d69c046541b485ff4d6085 100644
--- a/remoting/webapp/client_plugin.js
+++ b/remoting/webapp/client_plugin.js
@@ -31,6 +31,8 @@ remoting.ClientPlugin.prototype.onConnectionStatusUpdateHandler;
 remoting.ClientPlugin.prototype.onConnectionReadyHandler;
 /** @type {function(): void} Desktop size change callback. */
 remoting.ClientPlugin.prototype.onDesktopSizeUpdateHandler;
+/** @type {function(): void} Request a PIN from the user. */
+remoting.ClientPlugin.prototype.fetchPinHandler;
 
 /**
  * Initializes the plugin asynchronously and calls specified function
@@ -56,6 +58,8 @@ remoting.ClientPlugin.Feature = {
   INJECT_KEY_EVENT: 'injectKeyEvent',
   NOTIFY_CLIENT_DIMENSIONS: 'notifyClientDimensions',
   NOTIFY_CLIENT_RESOLUTION: 'notifyClientResolution',
+  ON_PIN_FETCHED: 'onPinFetched',
+  USE_ASYNC_PIN_DIALOG: 'useAsyncPinDialog',

[Sergey Ulanov, 2013/03/17 20:45:50]

Why do these need to be two separate features? Would we ever need one without
the other? Feature names do not need to match method names. I think you could
have just one feature (e.g. called asyncPin) 

[Jamie, 2013/03/18 20:28:23]

+1

[rmsousa, 2013/03/18 21:58:01]

Done.

   PAUSE_VIDEO: 'pauseVideo',
   PAUSE_AUDIO: 'pauseAudio',
   REMAP_KEY: 'remapKey',
@@ -130,7 +134,7 @@ remoting.ClientPlugin.prototype.remapKey =
  * @param {number} keycode The USB-style code of the key.
  * @param {Boolean} trap True to enable trapping, False to disable.
  */
-remoting.ClientPlugin.prototype.trapKey = function(keycode, trap) {}
+remoting.ClientPlugin.prototype.trapKey = function(keycode, trap) {};
 
 /**
  * Returns an associative array with a set of stats for this connection.
@@ -172,3 +176,16 @@ remoting.ClientPlugin.prototype.pauseVideo =
  */
 remoting.ClientPlugin.prototype.pauseAudio =
     function(pause) {};
+
+/**
+ * Gives the client authenticator the PIN.
+ *
+ * @param {string} pin The PIN.
+ */
+remoting.ClientPlugin.prototype.onPinFetched =
+    function(pin) {};

[Jamie, 2013/03/18 20:28:23]

Nit: No need to wrap this line.

[rmsousa, 2013/03/18 21:58:01]

Done.

+
+/**
+ * Tells the plugin to ask for the PIN asynchronously.
+ */
+remoting.ClientPlugin.prototype.useAsyncPinDialog = function() {};