Extracted InkDropAnimator class from InkDropAnimationController.

Extracted InkDropAnimator class and InkDropState enum from InkDropAnimationController.

NOTE: This is based on this review: https://codereview.chromium.org/1280953003/ .

Follow up review: https://codereview.chromium.org/1298513003/

The InkDropAnimationController is becoming overloaded and the ink drop animation is only going to become more complex. Thus it will be easier to iterate on it if it becomes contained in it's own .h/.cc files.

TEST=Tested clicking, touching, and long pressing all the affected
ToolbarButton's with and without material design enabled. Verified
reasonable visuals and no crashes.

BUG=517903
Committed: https://crrev.com/2c31473df0db630276fbb6f91379359ee65fbfc9
Cr-Commit-Position: refs/heads/master@{#344589}

[bruthig, 2015-08-11 17:52:44]

bruthig@chromium.org changed reviewers:
+ jonross@chromium.org, tdanderson@chromium.org

[bruthig, 2015-08-11 17:52:44]

jonross@, tdanderson@, can you guys PTAL before I send it off for OWNERS review?

[bruthig, 2015-08-14 19:40:25]

bruthig@chromium.org changed reviewers:
+ pkasting@chromium.org, sadrul@chromium.org

[bruthig, 2015-08-14 19:40:26]

pkasting@, Please review changes in:
 - chrome/browser/*

sadrul@, Please review changes in:
 - ui/views/*

[Peter Kasting, 2015-08-14 19:52:30]

I'm confused, are you not landing the other CL I just R+ed, and instead landing
this as a larger merged CL?  If so, are there any differences I actually need to
review in this CL?  If not, RS LGTM.

[bruthig, 2015-08-14 19:55:23]

bruthig@chromium.org changed reviewers:
- pkasting@chromium.org

[bruthig, 2015-08-14 19:55:23]

Sorry my bad pkasting@, I didn't set the proper diff base when uploading and
then added you to this review incorrectly.  Please ignore.

[jonross, 2015-08-19 21:41:02]

Minor request, basically a nit. Otherwise LGTM

https://codereview.chromium.org/1286693004/diff/180001/ui/views/animation/ink...
File ui/views/animation/ink_drop_animation.cc (right):

https://codereview.chromium.org/1286693004/diff/180001/ui/views/animation/ink...
ui/views/animation/ink_drop_animation.cc:208: ui::Layer*
InkDropAnimation::GetRootLayer() {
This is just a simple accessor.

Change to:

ui::Layer* root_layer() {
  return root_layer_.get();
}

It can be in the .h

[tdanderson, 2015-08-19 22:13:26]

lgtm also

[sadrul, 2015-08-20 06:32:38]

lgtm

https://codereview.chromium.org/1286693004/diff/180001/ui/views/animation/ink...
File ui/views/animation/ink_drop_animation.h (right):

https://codereview.chromium.org/1286693004/diff/180001/ui/views/animation/ink...
ui/views/animation/ink_drop_animation.h:35: // Set the size of the ink drop.
*Sets

https://codereview.chromium.org/1286693004/diff/180001/ui/views/views.gyp
File ui/views/views.gyp (right):

https://codereview.chromium.org/1286693004/diff/180001/ui/views/views.gyp#new...
ui/views/views.gyp:23: 'animation/ink_drop_animation.h',
I think this should go after line 16?

[bruthig, 2015-08-20 12:16:22]

https://codereview.chromium.org/1286693004/diff/180001/ui/views/animation/ink...
File ui/views/animation/ink_drop_animation.cc (right):

https://codereview.chromium.org/1286693004/diff/180001/ui/views/animation/ink...
ui/views/animation/ink_drop_animation.cc:208: ui::Layer*
InkDropAnimation::GetRootLayer() {
On 2015/08/19 21:41:01, jonross wrote:
> This is just a simple accessor.
> 
> Change to:
> 
> ui::Layer* root_layer() {
>   return root_layer_.get();
> }
> 
> It can be in the .h

Done.

https://codereview.chromium.org/1286693004/diff/180001/ui/views/animation/ink...
File ui/views/animation/ink_drop_animation.h (right):

https://codereview.chromium.org/1286693004/diff/180001/ui/views/animation/ink...
ui/views/animation/ink_drop_animation.h:35: // Set the size of the ink drop.
On 2015/08/20 06:32:38, sadrul wrote:
> *Sets

Done.

https://codereview.chromium.org/1286693004/diff/180001/ui/views/views.gyp
File ui/views/views.gyp (right):

https://codereview.chromium.org/1286693004/diff/180001/ui/views/views.gyp#new...
ui/views/views.gyp:23: 'animation/ink_drop_animation.h',
On 2015/08/20 06:32:38, sadrul wrote:
> I think this should go after line 16?

Done, fixed other ordering as well.

[bruthig, 2015-08-20 15:21:42]

The CQ bit was checked by bruthig@chromium.org

[bruthig, 2015-08-20 15:21:42]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkasting@chromium.org, tdanderson@chromium.org, jonross@chromium.org,
sadrul@chromium.org
Link to the patchset: https://codereview.chromium.org/1286693004/#ps210001
(title: "Merge branch 'master'")

[commit-bot: I haz the power, 2015-08-20 15:21:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1286693004/210001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1286693004/210001

[commit-bot: I haz the power, 2015-08-20 16:35:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-20 16:35:16]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[bruthig, 2015-08-20 20:29:39]

The CQ bit was checked by bruthig@chromium.org

[commit-bot: I haz the power, 2015-08-20 20:29:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1286693004/210001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1286693004/210001

[commit-bot: I haz the power, 2015-08-20 21:50:53]

Committed patchset #12 (id:210001)

[commit-bot: I haz the power, 2015-08-20 21:51:29]

Patchset 12 (id:??) landed as
https://crrev.com/2c31473df0db630276fbb6f91379359ee65fbfc9
Cr-Commit-Position: refs/heads/master@{#344589}