Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 1286653004: Remove redundant handle in ScopeIterator constructor. (Closed)

Created:
5 years, 4 months ago by Yang
Modified:
5 years, 4 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove redundant handle in ScopeIterator constructor. R=bmeurer@chromium.org Committed: https://crrev.com/ce519749433fd922e11c2378b03c672d09aca235 Cr-Commit-Position: refs/heads/master@{#30106}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M src/debug/debug-scopes.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
Yang
5 years, 4 months ago (2015-08-11 08:14:39 UTC) #1
Benedikt Meurer
lgtm
5 years, 4 months ago (2015-08-11 08:53:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1286653004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1286653004/1
5 years, 4 months ago (2015-08-11 09:01:11 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-11 09:32:31 UTC) #5
commit-bot: I haz the power
5 years, 4 months ago (2015-08-11 09:32:55 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ce519749433fd922e11c2378b03c672d09aca235
Cr-Commit-Position: refs/heads/master@{#30106}

Powered by Google App Engine
This is Rietveld 408576698