Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats.h

Issue 1286643002: Fix UMA to track video data usage. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Init prefs in compression stats map Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats.h
diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats.h b/components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats.h
index e94c557a163a11da9d92fa55b812f6718e3dad20..fe8d7da63bc5faeea1d3f6c33c4126a2318264fc 100644
--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats.h
+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats.h
@@ -5,6 +5,8 @@
#ifndef COMPONENTS_DATA_REDUCTION_PROXY_CORE_BROWSER_DATA_REDUCTION_PROXY_COMPRESSION_STATS_H_
#define COMPONENTS_DATA_REDUCTION_PROXY_CORE_BROWSER_DATA_REDUCTION_PROXY_COMPRESSION_STATS_H_
+#include <stdint.h>
+
#include <map>
#include <string>
@@ -148,6 +150,10 @@ class DataReductionProxyCompressionStats
// The pref is later written to |pref service_|.
void SetInt64(const char* pref_path, int64 pref_value);
+ // Increments the pref value in the |DataReductionProxyPrefMap| map.
+ // The pref is later written to |pref service_|.
+ void IncrementInt64Pref(const char* pref_path, int64_t pref_increment);
+
// Gets the pref list at |pref_path| from the |DataReductionProxyPrefMap|.
base::ListValue* GetList(const char* pref_path);
@@ -176,6 +182,17 @@ class DataReductionProxyCompressionStats
const std::string& mime_type,
base::Time now);
+ void IncrementDailyUmaPrefs(int64_t original_size,
+ int64_t received_size,
+ const char* original_size_pref,
+ const char* received_size_pref,
+ bool data_reduction_proxy_enabled,
+ const char* original_size_with_proxy_enabled_pref,
+ const char* recevied_size_with_proxy_enabled_pref,
+ bool via_data_reduction_proxy,
+ const char* original_size_via_proxy_pref,
+ const char* received_size_via_proxy_pref);
+
// Record UMA with data savings bytes and percent over the past
// |DataReductionProxy::kNumDaysInHistorySummary| days. These numbers
// are displayed to users as their data savings.
@@ -192,8 +209,8 @@ class DataReductionProxyCompressionStats
void ClearInMemoryDataUsage();
// Normalizes the hostname for data usage attribution. Returns a substring
- // without protocol and "www".
- // Example: "http://www.finance.google.com" -> "finance.google.com"
+ // without the protocol.
+ // Example: "http://www.finance.google.com" -> "www.finance.google.com"
static std::string NormalizeHostname(const std::string& host);
DataReductionProxyService* service_;
« no previous file with comments | « no previous file | components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698