Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Unified Diff: media/base/video_frame.h

Issue 1286623002: Update padding/alignment constants to match ffmpeg. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | media/base/video_frame_unittest.cc » ('j') | media/base/video_frame_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/video_frame.h
diff --git a/media/base/video_frame.h b/media/base/video_frame.h
index 80169cbe822990ca487fa5993d12bc2c5a7aa0d0..0158eab4e1838a1536b53e67b511897d8310f731 100644
--- a/media/base/video_frame.h
+++ b/media/base/video_frame.h
@@ -28,8 +28,10 @@ namespace media {
class MEDIA_EXPORT VideoFrame : public base::RefCountedThreadSafe<VideoFrame> {
public:
enum {
- kFrameSizeAlignment = 16,
- kFrameSizePadding = 16,
+ // These values are chosen according to like values in FFmpeg. See static
DaleCurtis 2015/08/11 00:31:30 Hmm, I wonder if we should instead add a construct
miu 2015/08/11 02:53:55 +1. This approach wastes memory for the non-ffmpe
+ // asserts in ffmpeg_common.
+ kFrameSizeAlignment = 32,
+ kFrameSizePadding = 47,
kFrameAddressAlignment = 32
};
« no previous file with comments | « no previous file | media/base/video_frame_unittest.cc » ('j') | media/base/video_frame_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698