Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 12866: Fixed regexp zone issue (Closed)

Created:
12 years ago by Christian Plesner Hansen
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Fixed issue where regexps were parsed without having set up a zone scope, leading to zone exhaustion. Added assertion that a zone scope exists on zone allocation.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -5 lines) Patch
M src/jsregexp.cc View 2 chunks +3 lines, -1 line 0 comments Download
M src/v8-counters.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/zone.h View 2 chunks +4 lines, -1 line 0 comments Download
M src/zone.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/zone-inl.h View 2 chunks +8 lines, -0 lines 0 comments Download
M test/cctest/test-ast.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Christian Plesner Hansen
12 years ago (2008-12-02 13:57:13 UTC) #1
Mads Ager (chromium)
12 years ago (2008-12-02 13:59:06 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698