Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Unified Diff: chrome/browser/password_manager/password_manager_browsertest.cc

Issue 1286593003: [Password Manager] Store forms with field name and id attributes missing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed Vaclav's Review Comments. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/password_manager_browsertest.cc
diff --git a/chrome/browser/password_manager/password_manager_browsertest.cc b/chrome/browser/password_manager/password_manager_browsertest.cc
index 6a1f0b8c3d1bf7a86ea39317e89351d79a8fa5a4..7e4cad165fe801608d60f02e76da05d7762c643f 100644
--- a/chrome/browser/password_manager/password_manager_browsertest.cc
+++ b/chrome/browser/password_manager/password_manager_browsertest.cc
@@ -893,8 +893,8 @@ IN_PROC_BROWSER_TEST_F(PasswordManagerBrowserTestBase,
}
IN_PROC_BROWSER_TEST_F(PasswordManagerBrowserTestBase,
- NoPromptForInputElementWithoutIdAndName) {
- // Check that no prompt is shown for forms where the input fields lack both
+ PromptForInputElementWithoutIdAndName) {
+ // Check that prompt is shown for forms where the input fields lack both
// the "id" and the "name" attributes.
NavigateToFile("/password/password_form.html");
@@ -910,7 +910,7 @@ IN_PROC_BROWSER_TEST_F(PasswordManagerBrowserTestBase,
"form.children[2].click()"; // form.children[2] is the submit button.
ASSERT_TRUE(content::ExecuteScript(RenderViewHost(), fill_and_submit));
observer.Wait();
- EXPECT_FALSE(prompt_observer->IsShowingPrompt());
+ EXPECT_TRUE(prompt_observer->IsShowingPrompt());
dvadym 2015/09/07 15:19:58 Could you please check that correct credential is
Pritam Nikam 2015/09/08 15:09:36 Done.
}
// Test for checking that no prompt is shown for URLs with file: scheme.

Powered by Google App Engine
This is Rietveld 408576698