Index: chrome/browser/password_manager/password_manager_browsertest.cc |
diff --git a/chrome/browser/password_manager/password_manager_browsertest.cc b/chrome/browser/password_manager/password_manager_browsertest.cc |
index 6a1f0b8c3d1bf7a86ea39317e89351d79a8fa5a4..e3ca5ae341ca8856a60f1954bb9d172983f1199f 100644 |
--- a/chrome/browser/password_manager/password_manager_browsertest.cc |
+++ b/chrome/browser/password_manager/password_manager_browsertest.cc |
@@ -893,8 +893,8 @@ IN_PROC_BROWSER_TEST_F(PasswordManagerBrowserTestBase, |
} |
IN_PROC_BROWSER_TEST_F(PasswordManagerBrowserTestBase, |
- NoPromptForInputElementWithoutIdAndName) { |
- // Check that no prompt is shown for forms where the input fields lack both |
+ PromptForInputElementWithoutIdAndName) { |
+ // Check that prompt is shown for forms where the input fields lack both |
// the "id" and the "name" attributes. |
NavigateToFile("/password/password_form.html"); |
@@ -910,7 +910,7 @@ IN_PROC_BROWSER_TEST_F(PasswordManagerBrowserTestBase, |
"form.children[2].click()"; // form.children[2] is the submit button. |
ASSERT_TRUE(content::ExecuteScript(RenderViewHost(), fill_and_submit)); |
observer.Wait(); |
- EXPECT_FALSE(prompt_observer->IsShowingPrompt()); |
+ EXPECT_TRUE(prompt_observer->IsShowingPrompt()); |
} |
// Test for checking that no prompt is shown for URLs with file: scheme. |
@@ -2126,4 +2126,23 @@ IN_PROC_BROWSER_TEST_F(PasswordManagerBrowserTestBase, |
} |
#endif |
+// Test that loading a non-password form will not create a PasswordFormManager |
+// instance. |
+IN_PROC_BROWSER_TEST_F(PasswordManagerBrowserTestBase, |
+ NoPasswordFormManagerForNonPasswordForms) { |
+ password_manager::PasswordManager* password_manager = |
+ ChromePasswordManagerClient::FromWebContents(WebContents()) |
+ ->GetPasswordManager(); |
+ |
+ // Verify that the PasswordFormManager will get instantiated post a password |
+ // form navigation. |
+ NavigateToFile("/password/password_form.html"); |
+ ASSERT_NE(0ul, password_manager->PendingLoginManagersCount()); |
+ |
+ // Verify that none PasswordFormManager instace will exist post a non-password |
+ // form navigation. |
+ NavigateToFile("/password/non_password_form.html"); |
+ ASSERT_EQ(0ul, password_manager->PendingLoginManagersCount()); |
+} |
+ |
} // namespace password_manager |