[Password Manager] Store forms with field name and id attributes missing.

components/password_manager/core/browser/password_form_manager_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/memory/scoped_ptr.h"
 #include "base/prefs/pref_registry_simple.h"
 #include "base/prefs/pref_service.h"
 #include "base/prefs/testing_pref_service.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/test/histogram_tester.h"
@@ skipping 864 matching lines @@
 
   form_manager()->Save();
 
   // |other_possible_usernames| should also be empty, but username_value should
   // be changed to match |new_username|.
   EXPECT_EQ(saved_match()->other_possible_usernames[0],
             saved_result.username_value);
   EXPECT_TRUE(saved_result.other_possible_usernames.empty());
 }
 
-TEST_F(PasswordFormManagerTest, TestValidForms) {
-  // User submits credentials for the observed form.
-  PasswordForm credentials = *observed_form();
-  credentials.scheme = PasswordForm::SCHEME_HTML;
-  credentials.username_value = saved_match()->username_value;
-  credentials.password_value = saved_match()->password_value;
-
-  // An alternate version of the form that also has a new_password_element.
-  PasswordForm new_credentials(*observed_form());
-  new_credentials.new_password_element = ASCIIToUTF16("NewPasswd");
-  new_credentials.new_password_value = ASCIIToUTF16("test1new");
-
-  // Form with both username_element and password_element.
-  PasswordFormManager manager1(password_manager(), client(), kNoDriver,
-                               credentials, false);
-  SimulateMatchingPhase(&manager1, RESULT_NO_MATCH);
-  EXPECT_TRUE(manager1.HasValidPasswordForm());
-
-  // Form with username_element, password_element, and new_password_element.
-  PasswordFormManager manager2(password_manager(), client(), kNoDriver,
-                               new_credentials, false);
-  SimulateMatchingPhase(&manager2, RESULT_NO_MATCH);
-  EXPECT_TRUE(manager2.HasValidPasswordForm());
-
-  // Form with username_element and only new_password_element.
-  new_credentials.password_element.clear();
-  PasswordFormManager manager3(password_manager(), client(), kNoDriver,
-                               new_credentials, false);
-  SimulateMatchingPhase(&manager3, RESULT_NO_MATCH);
-  EXPECT_TRUE(manager3.HasValidPasswordForm());
-
-  // Form without a username_element but with a password_element.
-  credentials.username_element.clear();
-  PasswordFormManager manager4(password_manager(), client(), kNoDriver,
-                               credentials, false);
-  SimulateMatchingPhase(&manager4, RESULT_NO_MATCH);
-  EXPECT_TRUE(manager4.HasValidPasswordForm());
-
-  // Form without a username_element but with a new_password_element.
-  new_credentials.username_element.clear();
-  PasswordFormManager manager5(password_manager(), client(), kNoDriver,
-                               new_credentials, false);
-  SimulateMatchingPhase(&manager5, RESULT_NO_MATCH);
-  EXPECT_TRUE(manager5.HasValidPasswordForm());
-
-  // Form without a password_element but with a username_element.
-  credentials.username_element = saved_match()->username_element;
-  credentials.password_element.clear();
-  PasswordFormManager manager6(password_manager(), client(), kNoDriver,
-                               credentials, false);
-  SimulateMatchingPhase(&manager6, RESULT_NO_MATCH);
-  EXPECT_FALSE(manager6.HasValidPasswordForm());
-
-  // Form with neither a password_element nor a username_element.
-  credentials.username_element.clear();
-  credentials.password_element.clear();
-  PasswordFormManager manager7(password_manager(), client(), kNoDriver,
-                               credentials, false);
-  SimulateMatchingPhase(&manager7, RESULT_NO_MATCH);
-  EXPECT_FALSE(manager7.HasValidPasswordForm());
-}
-
-TEST_F(PasswordFormManagerTest, TestValidFormsBasic) {
-  // User submits credentials for the observed form.
-  PasswordForm credentials = *observed_form();
-  credentials.scheme = PasswordForm::SCHEME_BASIC;
-  credentials.username_value = saved_match()->username_value;
-  credentials.password_value = saved_match()->password_value;
-
-  // Form with both username_element and password_element.
-  PasswordFormManager manager1(password_manager(), client(), kNoDriver,
-                               credentials, false);
-  SimulateMatchingPhase(&manager1, RESULT_NO_MATCH);
-  EXPECT_TRUE(manager1.HasValidPasswordForm());
-
-  // Form without a username_element but with a password_element.
-  credentials.username_element.clear();
-  PasswordFormManager manager2(password_manager(), client(), kNoDriver,
-                               credentials, false);
-  SimulateMatchingPhase(&manager2, RESULT_NO_MATCH);
-  EXPECT_TRUE(manager2.HasValidPasswordForm());
-
-  // Form without a password_element but with a username_element.
-  credentials.username_element = saved_match()->username_element;
-  credentials.password_element.clear();
-  PasswordFormManager manager3(password_manager(), client(), kNoDriver,
-                               credentials, false);
-  SimulateMatchingPhase(&manager3, RESULT_NO_MATCH);
-  EXPECT_TRUE(manager3.HasValidPasswordForm());
-
-  // Form with neither a password_element nor a username_element.
-  credentials.username_element.clear();
-  credentials.password_element.clear();
-  PasswordFormManager manager4(password_manager(), client(), kNoDriver,
-                               credentials, false);
-  SimulateMatchingPhase(&manager4, RESULT_NO_MATCH);
-  EXPECT_TRUE(manager4.HasValidPasswordForm());
-}
-
 TEST_F(PasswordFormManagerTest, TestSendNotBlacklistedMessage_NoCredentials) {
   // First time sign-up attempt. Password store does not contain matching
   // credentials. AllowPasswordGenerationForForm should be called to send the
   // "not blacklisted" message.
   EXPECT_CALL(*(client()->mock_driver()), AllowPasswordGenerationForForm(_))
       .Times(1);
   form_manager()->SimulateFetchMatchingLoginsFromPasswordStore();
   form_manager()->OnGetPasswordStoreResults(ScopedVector<PasswordForm>());
 }
 
@@ skipping 1023 matching lines @@
   EXPECT_CALL(*mock_store(), UpdateLogin(_))
       .WillOnce(testing::SaveArg<0>(&new_credentials));
   form_manager()->Save();
 
   EXPECT_EQ(PasswordForm::TYPE_GENERATED, new_credentials.type);
   histogram_tester.ExpectBucketCount("PasswordGeneration.SubmissionEvent",
                                      metrics_util::PASSWORD_USED, 1);
 }
 
 }  // namespace password_manager