Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(625)

Side by Side Diff: components/password_manager/core/browser/password_form_manager.h

Issue 1286593003: [Password Manager] Store forms with field name and id attributes missing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed mac bot failure. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSWORD_FORM_MANAGER_H_ 5 #ifndef COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSWORD_FORM_MANAGER_H_
6 #define COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSWORD_FORM_MANAGER_H_ 6 #define COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSWORD_FORM_MANAGER_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 #include <string> 9 #include <string>
10 #include <vector> 10 #include <vector>
(...skipping 95 matching lines...) Expand 10 before | Expand all | Expand 10 after
106 // Used by PasswordManager to determine whether or not to display 106 // Used by PasswordManager to determine whether or not to display
107 // a SavePasswordBar when given the green light to save the PasswordForm 107 // a SavePasswordBar when given the green light to save the PasswordForm
108 // managed by this. 108 // managed by this.
109 bool IsNewLogin() const; 109 bool IsNewLogin() const;
110 110
111 // Returns true if the current pending credentials were found using 111 // Returns true if the current pending credentials were found using
112 // origin matching of the public suffix, instead of the signon realm of the 112 // origin matching of the public suffix, instead of the signon realm of the
113 // form. 113 // form.
114 bool IsPendingCredentialsPublicSuffixMatch() const; 114 bool IsPendingCredentialsPublicSuffixMatch() const;
115 115
116 // Checks if the form is a valid password form. Forms which lack password
117 // field are not considered valid.
118 bool HasValidPasswordForm() const;
119
120 // Through |driver|, supply the associated frame with appropriate information 116 // Through |driver|, supply the associated frame with appropriate information
121 // (fill data, whether to allow password generation, etc.). If this is called 117 // (fill data, whether to allow password generation, etc.). If this is called
122 // before |this| has data from the PasswordStore, the execution will be 118 // before |this| has data from the PasswordStore, the execution will be
123 // delayed until the data arrives. 119 // delayed until the data arrives.
124 void ProcessFrame(const base::WeakPtr<PasswordManagerDriver>& driver); 120 void ProcessFrame(const base::WeakPtr<PasswordManagerDriver>& driver);
125 121
126 void OnGetPasswordStoreResults( 122 void OnGetPasswordStoreResults(
127 ScopedVector<autofill::PasswordForm> results) override; 123 ScopedVector<autofill::PasswordForm> results) override;
128 124
129 // A user opted to 'never remember' passwords for this form. 125 // A user opted to 'never remember' passwords for this form.
(...skipping 339 matching lines...) Expand 10 before | Expand all | Expand 10 after
469 // as our classification of the form can change depending on what data the 465 // as our classification of the form can change depending on what data the
470 // user has entered. 466 // user has entered.
471 FormType form_type_; 467 FormType form_type_;
472 468
473 DISALLOW_COPY_AND_ASSIGN(PasswordFormManager); 469 DISALLOW_COPY_AND_ASSIGN(PasswordFormManager);
474 }; 470 };
475 471
476 } // namespace password_manager 472 } // namespace password_manager
477 473
478 #endif // COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSWORD_FORM_MANAGER_H_ 474 #endif // COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSWORD_FORM_MANAGER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698