Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Side by Side Diff: components/password_manager/core/browser/password_form_manager.h

Issue 1286593003: [Password Manager] Store forms with field name and id attributes missing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSWORD_FORM_MANAGER_H_ 5 #ifndef COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSWORD_FORM_MANAGER_H_
6 #define COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSWORD_FORM_MANAGER_H_ 6 #define COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSWORD_FORM_MANAGER_H_
7 7
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 94 matching lines...) Expand 10 before | Expand all | Expand 10 after
105 // Used by PasswordManager to determine whether or not to display 105 // Used by PasswordManager to determine whether or not to display
106 // a SavePasswordBar when given the green light to save the PasswordForm 106 // a SavePasswordBar when given the green light to save the PasswordForm
107 // managed by this. 107 // managed by this.
108 bool IsNewLogin() const; 108 bool IsNewLogin() const;
109 109
110 // Returns true if the current pending credentials were found using 110 // Returns true if the current pending credentials were found using
111 // origin matching of the public suffix, instead of the signon realm of the 111 // origin matching of the public suffix, instead of the signon realm of the
112 // form. 112 // form.
113 bool IsPendingCredentialsPublicSuffixMatch() const; 113 bool IsPendingCredentialsPublicSuffixMatch() const;
114 114
115 // Checks if the form is a valid password form. Forms which lack password
116 // field are not considered valid.
117 bool HasValidPasswordForm() const;
118
119 // Through |driver|, supply the associated frame with appropriate information 115 // Through |driver|, supply the associated frame with appropriate information
120 // (fill data, whether to allow password generation, etc.). If this is called 116 // (fill data, whether to allow password generation, etc.). If this is called
121 // before |this| has data from the PasswordStore, the execution will be 117 // before |this| has data from the PasswordStore, the execution will be
122 // delayed until the data arrives. 118 // delayed until the data arrives.
123 void ProcessFrame(const base::WeakPtr<PasswordManagerDriver>& driver); 119 void ProcessFrame(const base::WeakPtr<PasswordManagerDriver>& driver);
124 120
125 void OnGetPasswordStoreResults( 121 void OnGetPasswordStoreResults(
126 ScopedVector<autofill::PasswordForm> results) override; 122 ScopedVector<autofill::PasswordForm> results) override;
127 123
128 // A user opted to 'never remember' passwords for this form. 124 // A user opted to 'never remember' passwords for this form.
(...skipping 329 matching lines...) Expand 10 before | Expand all | Expand 10 after
458 // as our classification of the form can change depending on what data the 454 // as our classification of the form can change depending on what data the
459 // user has entered. 455 // user has entered.
460 FormType form_type_; 456 FormType form_type_;
461 457
462 DISALLOW_COPY_AND_ASSIGN(PasswordFormManager); 458 DISALLOW_COPY_AND_ASSIGN(PasswordFormManager);
463 }; 459 };
464 460
465 } // namespace password_manager 461 } // namespace password_manager
466 462
467 #endif // COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSWORD_FORM_MANAGER_H_ 463 #endif // COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSWORD_FORM_MANAGER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698