Use list of isolates in profiler

runtime/vm/isolate.h

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_ISOLATE_H_
 #define VM_ISOLATE_H_
 
 #include "include/dart_api.h"
 #include "platform/assert.h"
 #include "platform/thread.h"
@@ skipping 18 matching lines @@
 class DeoptContext;
 class Field;
 class Function;
 class HandleScope;
 class HandleVisitor;
 class Heap;
 class ICData;
 class Instance;
 class IsolateProfilerData;
 class IsolateSpawnState;
+class InterruptableThreadState;
 class LongJumpScope;
 class MessageHandler;
 class Mutex;
 class Object;
 class ObjectPointerVisitor;
 class ObjectStore;
 class RawInstance;
 class RawArray;
 class RawContext;
 class RawDouble;
@@ skipping 19 matching lines @@
   V(Array)                                                                     \
   V(String)                                                                    \
   V(Instance)                                                                  \
   V(Function)                                                                  \
   V(Field)                                                                     \
   V(Class)                                                                     \
   V(AbstractType)                                                              \
   V(TypeParameter)                                                             \
   V(TypeArguments)                                                             \
 
+
+class IsolateVisitor {
+ public:
+  virtual ~IsolateVisitor() {}
+
+  virtual void VisitIsolate(Isolate* isolate) = 0;
+
+ private:

[siva, 2014/02/06 00:37:24]

DISALLOW stuff here?

[Cutch, 2014/02/06 17:51:51]

Done.

+};
+
+
 class Isolate : public BaseIsolate {
  public:
   ~Isolate();
 
   static inline Isolate* Current() {
     return reinterpret_cast<Isolate*>(Thread::GetThreadLocal(isolate_key));
   }
 
   static void SetCurrent(Isolate* isolate);
 
@@ skipping 310 matching lines @@
   }
 
   Mutex* profiler_data_mutex() {
     return &profiler_data_mutex_;
   }
 
   void set_profiler_data(IsolateProfilerData* profiler_data) {
     profiler_data_ = profiler_data;
   }
 
-  IsolateProfilerData* profiler_data() {
+  IsolateProfilerData* profiler_data() const {
     return profiler_data_;
   }
 
   void PrintToJSONStream(JSONStream* stream);
 
+  void set_thread_state(InterruptableThreadState* state) {
+    ASSERT((thread_state_ == NULL) || (state == NULL));
+    thread_state_ = state;
+  }
+
+  InterruptableThreadState* thread_state() const {
+    return thread_state_;
+  }
+
+  static void VisitIsolates(IsolateVisitor* visitor);
+
  private:
   Isolate();
 
   void BuildName(const char* name_prefix);
   void PrintInvokedFunctions();
 
   template<class T> T* AllocateReusableHandle();
 
   static ThreadLocalKey isolate_key;
 
@@ skipping 36 matching lines @@
   intptr_t stack_frame_index_;
   ObjectHistogram* object_histogram_;
 
   bool cha_used_;
 
   // Ring buffer of objects assigned an id.
   ObjectIdRing* object_id_ring_;
 
   IsolateProfilerData* profiler_data_;
   Mutex profiler_data_mutex_;
+  InterruptableThreadState* thread_state_;
 
   // Reusable handles support.
 #define REUSABLE_HANDLE_FIELDS(object)                                         \
   object* object##_handle_;                                                    \
 
   REUSABLE_HANDLE_LIST(REUSABLE_HANDLE_FIELDS)
 #undef REUSABLE_HANDLE_FIELDS
   VMHandles reusable_handles_;
 
   static Dart_IsolateCreateCallback create_callback_;
   static Dart_IsolateInterruptCallback interrupt_callback_;
   static Dart_IsolateUnhandledExceptionCallback unhandled_exception_callback_;
   static Dart_IsolateShutdownCallback shutdown_callback_;
   static Dart_FileOpenCallback file_open_callback_;
   static Dart_FileReadCallback file_read_callback_;
   static Dart_FileWriteCallback file_write_callback_;
   static Dart_FileCloseCallback file_close_callback_;
   static Dart_EntropySource entropy_source_callback_;
   static Dart_IsolateInterruptCallback vmstats_callback_;
   static Dart_ServiceIsolateCreateCalback service_create_callback_;
 
+  // Manage list of existing isolates.
+  static void IsolateCreated(Isolate* isolate);
+  static void IsolateShutdown(Isolate* isolate);

[siva, 2014/02/06 00:37:24]

Why not call these functions
AddIsolateToList and RemoveIsolateFromList

[Cutch, 2014/02/06 17:51:51]

Done.

+  static void CheckForDuplicateThreadState(InterruptableThreadState* state);
+  static Monitor* isolates_monitor_;
+  static Isolate* isolates_head_;

[siva, 2014/02/06 00:37:24]

should we call these isolates_list_monitor_ and isolates_list_ ?

[Cutch, 2014/02/06 17:51:51]

Done.

+  Isolate* next_;

[siva, 2014/02/06 00:37:24]

style guide states this instance field should be grouped with the other instance
fields above. You could add a comment stating it is used to chain the isolate
into the isolate list.

[Cutch, 2014/02/06 17:51:51]

Done.

+
   friend class ReusableHandleScope;
   friend class ReusableObjectHandleScope;
+  friend class ThreadInterrupter;
+  friend class ThreadInterrupterAndroid;
+  friend class ThreadInterrupterMacOS;
+  friend class ThreadInterrupterLinux;
+  friend class ThreadInterrupterWin;

[siva, 2014/02/06 00:37:24]

Are these friends still needed?

[Cutch, 2014/02/06 17:51:51]

Nope. Removed.

+
   DISALLOW_COPY_AND_ASSIGN(Isolate);
 };
 
 
 // When we need to execute code in an isolate, we use the
 // StartIsolateScope.
 class StartIsolateScope {
  public:
   explicit StartIsolateScope(Isolate* new_isolate)
       : new_isolate_(new_isolate), saved_isolate_(Isolate::Current()) {
@@ skipping 79 matching lines @@
   char* script_url_;
   char* library_url_;
   char* class_name_;
   char* function_name_;
   char* exception_callback_name_;
 };
 
 }  // namespace dart
 
 #endif  // VM_ISOLATE_H_