Use list of isolates in profiler

runtime/vm/isolate.h

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_ISOLATE_H_
 #define VM_ISOLATE_H_
 
 #include "include/dart_api.h"
 #include "platform/assert.h"
 #include "platform/thread.h"
@@ skipping 18 matching lines @@
 class DeoptContext;
 class Field;
 class Function;
 class HandleScope;
 class HandleVisitor;
 class Heap;
 class ICData;
 class Instance;
 class IsolateProfilerData;
 class IsolateSpawnState;
+class InterruptableThreadState;
 class LongJumpScope;
 class MessageHandler;
 class Mutex;
 class Object;
 class ObjectPointerVisitor;
 class ObjectStore;
 class RawInstance;
 class RawArray;
 class RawContext;
 class RawDouble;
@@ skipping 346 matching lines @@
   }
 
   Mutex* profiler_data_mutex() {
     return &profiler_data_mutex_;
   }
 
   void set_profiler_data(IsolateProfilerData* profiler_data) {
     profiler_data_ = profiler_data;
   }
 
-  IsolateProfilerData* profiler_data() {
+  IsolateProfilerData* profiler_data() const {
     return profiler_data_;
   }
 
   void PrintToJSONStream(JSONStream* stream);
 
+  void set_thread_state(InterruptableThreadState* state) {
+    ASSERT((thread_state_ == NULL) || (state == NULL));
+    thread_state_ = state;
+  }
+
+  InterruptableThreadState* thread_state() const {
+    return thread_state_;
+  }
+
  private:
   Isolate();
 
   void BuildName(const char* name_prefix);
   void PrintInvokedFunctions();
 
   template<class T> T* AllocateReusableHandle();
 
   static ThreadLocalKey isolate_key;
 
@@ skipping 34 matching lines @@
   // Status support.
   char* stacktrace_;
   intptr_t stack_frame_index_;
   ObjectHistogram* object_histogram_;
 
   // Ring buffer of objects assigned an id.
   ObjectIdRing* object_id_ring_;
 
   IsolateProfilerData* profiler_data_;
   Mutex profiler_data_mutex_;
+  InterruptableThreadState* thread_state_;
 
   // Reusable handles support.
 #define REUSABLE_HANDLE_FIELDS(object)                                         \
   object* object##_handle_;                                                    \
 
   REUSABLE_HANDLE_LIST(REUSABLE_HANDLE_FIELDS)
 #undef REUSABLE_HANDLE_FIELDS
   VMHandles reusable_handles_;
 
   static Dart_IsolateCreateCallback create_callback_;
   static Dart_IsolateInterruptCallback interrupt_callback_;
   static Dart_IsolateUnhandledExceptionCallback unhandled_exception_callback_;
   static Dart_IsolateShutdownCallback shutdown_callback_;
   static Dart_FileOpenCallback file_open_callback_;
   static Dart_FileReadCallback file_read_callback_;
   static Dart_FileWriteCallback file_write_callback_;
   static Dart_FileCloseCallback file_close_callback_;
   static Dart_EntropySource entropy_source_callback_;
   static Dart_IsolateInterruptCallback vmstats_callback_;
   static Dart_ServiceIsolateCreateCalback service_create_callback_;
 
+  // List of existing isolates.
+  static void IsolateCreated(Isolate* isolate);
+  static void IsolateShutdown(Isolate* isolate);
+  static void ResizeIsolates(intptr_t new_capacity);
+  static intptr_t FindIsolateIndex(Isolate* isolate);
+  static void CheckNoIsolateHasThreadData(InterruptableThreadState* state);
+  static Monitor* isolates_monitor_;
+  static Isolate** isolates_;
+  static intptr_t isolates_capacity_;
+  static intptr_t isolates_size_;

[siva, 2014/02/05 19:09:15]

Why not just make the isolate list a singly linked list instead of a growable
array with the need to maintain size, capacity and grow it.

You could add a next pointer to the Isolate class and chain them up.

[Cutch, 2014/02/05 23:00:31]

Done.

+
   friend class ReusableHandleScope;
   friend class ReusableObjectHandleScope;
+  friend class ThreadInterrupter;
+  friend class ThreadInterrupterAndroid;
+  friend class ThreadInterrupterMacOS;
+  friend class ThreadInterrupterLinux;
+  friend class ThreadInterrupterWin;

[siva, 2014/02/05 19:09:15]

Seems weird that you are having to friend a bunch of OS specific classes in this
target independent class.

Maybe instead you should define an Iterator that takes a Visitor function as a
parameter similar to the heap iterator and have the Thread Interruptor provide a
visitor that interrupts isolates that have a non null thread state.

[Cutch, 2014/02/05 23:00:31]

Done.

+
   DISALLOW_COPY_AND_ASSIGN(Isolate);
 };
 
 
 // When we need to execute code in an isolate, we use the
 // StartIsolateScope.
 class StartIsolateScope {
  public:
   explicit StartIsolateScope(Isolate* new_isolate)
       : new_isolate_(new_isolate), saved_isolate_(Isolate::Current()) {
@@ skipping 79 matching lines @@
   char* script_url_;
   char* library_url_;
   char* class_name_;
   char* function_name_;
   char* exception_callback_name_;
 };
 
 }  // namespace dart
 
 #endif  // VM_ISOLATE_H_