Chromium Code Reviews

Issue 1286513002: Remove error-recovery TODO comments from bitcode parser. (Closed)

Created:
5 years, 4 months ago by Karl
Modified:
5 years, 4 months ago
Reviewers:
Jim Stichnoth, Derek Schuff
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove error-recovery TODO comments from bitcode parser. The bitcode parser contained a number of TODO commments about removing error recovery once the parser was implemented. This was based on the fact that (1) pnacl-sz in the browser didn't need it, and (2) it would be trivial to remove. The advantage of leaving error recovery in is that multiple errors can be found at once. It turns out it isn't so easy to remove, since several methods assume that recovery can be applied, and hence do not need propagate back up an (optional) error code. Parsing backs out relatively quickly anyway, since the code exits between bitcode records anyway. BUG=None R=stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=83ccadcf9ee6408bde0dbfe28a764de813a7bf31

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+0 lines, -17 lines)
M src/PNaClTranslator.cpp View 17 chunks +0 lines, -17 lines 0 comments

Messages

Total messages: 4 (1 generated)
Karl
5 years, 4 months ago (2015-08-10 20:14:05 UTC) #2
Jim Stichnoth
lgtm
5 years, 4 months ago (2015-08-12 01:33:01 UTC) #3
Karl
5 years, 4 months ago (2015-08-12 17:39:19 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
83ccadcf9ee6408bde0dbfe28a764de813a7bf31 (presubmit successful).

Powered by Google App Engine