Benchmark precision

benchmarks/base.js

 // Copyright 2008 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 102 matching lines @@
         if (runner.NotifyStart) runner.NotifyStart(suite.name);
         continuation = suite.RunStep(runner);
       }
       if (continuation && typeof window != 'undefined' && window.setTimeout) {
         window.setTimeout(RunStep, 100);
         return;
       }
     }
     if (runner.NotifyScore) {
       var score = BenchmarkSuite.GeometricMean(BenchmarkSuite.scores);
-      runner.NotifyScore(Math.round(100 * score));

[sandholm, 2008/12/02 12:54:16]

Just wondering if it would make sense to always simply do toPrecision(3) instead
of Math.round here in base.js. Then we would neither need the formatScore
function nor the changes in run.{html,js} files.

+      runner.NotifyScore(100 * score);
     }
   }
   RunStep();
 }
 
 
 // Counts the total number of registered benchmarks. Useful for
 // showing progress as a percentage.
 BenchmarkSuite.CountBenchmarks = function() {
   var result = 0;
@@ skipping 23 matching lines @@
 }
 
 
 // Notifies the runner that we're done with running a suite and that
 // we have a result which can be reported to the user if needed.
 BenchmarkSuite.prototype.NotifyResult = function() {
   var mean = BenchmarkSuite.GeometricMean(this.results);
   var score = this.reference / mean;
   BenchmarkSuite.scores.push(score);
   if (this.runner.NotifyResult) {
-    this.runner.NotifyResult(this.name, Math.round(100 * score));
+    this.runner.NotifyResult(this.name, 100 * score);
   }
 }
 
 
 // Notifies the runner that running a benchmark resulted in an error.
 BenchmarkSuite.prototype.NotifyError = function(error) {
   if (this.runner.NotifyError) {
     this.runner.NotifyError(this.name, error);
   }
   if (this.runner.NotifyStep) {
@@ skipping 34 matching lines @@
         suite.NotifyError(e);
         return null;
       }
       return RunNext;
     }
     suite.NotifyResult();
     return null;
   }
   return RunNext();
 }
+
+
+// Converts a score value to a string with at least three significant
+// digits.
+function formatScore(value) {
+  if (value > 100) {
+    return value.toFixed(0);
+  } else {
+    return value.toPrecision(3);
+  }
+}