Issue 12865: Benchmark precision

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12865: Benchmark precision (Closed)

Created:
12 years ago by Christian Plesner Hansen

Modified:
9 years, 7 months ago

Reviewers:
sandholm, asandholm

CC:
v8-dev

Visibility:
Public.

Description

Changed benchmark runners to always display at least three significant digits in the results.

Patch Set 1 #

Created: 12 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+18 lines, -6 lines)			Patch
M	benchmarks/base.js	View	3 chunks	+13 lines, -2 lines	1 comment	Download
M	benchmarks/run.html	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	benchmarks/run.js	View	2 chunks	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

sandholm

12 years ago (2008-12-02 12:54:16 UTC) #2

LGTM. 
One proposal to make the change even simpler, though. 
(Maybe too simple...)

http://codereview.chromium.org/12865/diff/1/2
File benchmarks/base.js (left):

http://codereview.chromium.org/12865/diff/1/2#oldcode123
Line 123: runner.NotifyScore(Math.round(100 * score));
Just wondering if it would make sense to always simply do toPrecision(3) instead
of Math.round here in base.js. Then we would neither need the formatScore
function nor the changes in run.{html,js} files.

Expand Messages | Collapse Messages