Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1159)

Unified Diff: runtime/observatory/tests/service/test_helper.dart

Issue 1286493003: Revert "Allow stepping when paused at isolate start." (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/observatory/tests/service/pause_on_start_then_step_test.dart ('k') | runtime/vm/debugger.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/observatory/tests/service/test_helper.dart
diff --git a/runtime/observatory/tests/service/test_helper.dart b/runtime/observatory/tests/service/test_helper.dart
index 6445f401ade454dafcd13b3b8fe7f774fc7e07df..4c492edefe43d0e274ae04b45b210de7eb01a9b1 100644
--- a/runtime/observatory/tests/service/test_helper.dart
+++ b/runtime/observatory/tests/service/test_helper.dart
@@ -26,12 +26,9 @@ class _TestLauncher {
Platform.script.toFilePath(),
_TESTEE_MODE_FLAG] {}
- Future<int> launch(bool pause_on_start, bool pause_on_exit) {
+ Future<int> launch(bool pause_on_exit) {
String dartExecutable = Platform.executable;
var fullArgs = [];
- if (pause_on_start == true) {
- fullArgs.add('--pause-isolates-on-start');
- }
if (pause_on_exit == true) {
fullArgs.add('--pause-isolates-on-exit');
}
@@ -52,7 +49,7 @@ class _TestLauncher {
var port = portExp.firstMatch(line).group(1);
portNumber = int.parse(port);
}
- if (pause_on_start || line == '') {
+ if (line == '') {
// Received blank line.
blank = true;
}
@@ -101,16 +98,12 @@ void runIsolateTests(List<String> mainArgs,
List<IsolateTest> tests,
{void testeeBefore(),
void testeeConcurrent(),
- bool pause_on_start,
bool pause_on_exit}) {
- assert(!pause_on_start || testeeBefore == null);
if (mainArgs.contains(_TESTEE_MODE_FLAG)) {
- if (!pause_on_start) {
- if (testeeBefore != null) {
- testeeBefore();
- }
- print(''); // Print blank line to signal that we are ready.
+ if (testeeBefore != null) {
+ testeeBefore();
}
+ print(''); // Print blank line to signal that we are ready.
if (testeeConcurrent != null) {
testeeConcurrent();
}
@@ -118,7 +111,7 @@ void runIsolateTests(List<String> mainArgs,
stdin.first.then((_) => exit(0));
} else {
var process = new _TestLauncher();
- process.launch(pause_on_start, pause_on_exit).then((port) {
+ process.launch(pause_on_exit).then((port) {
if (mainArgs.contains("--gdb")) {
port = 8181;
}
@@ -293,7 +286,6 @@ Future runVMTests(List<String> mainArgs,
List<VMTest> tests,
{Future testeeBefore(),
Future testeeConcurrent(),
- bool pause_on_start,
bool pause_on_exit}) async {
if (mainArgs.contains(_TESTEE_MODE_FLAG)) {
if (testeeBefore != null) {
@@ -307,7 +299,7 @@ Future runVMTests(List<String> mainArgs,
stdin.first.then((_) => exit(0));
} else {
var process = new _TestLauncher();
- process.launch(pause_on_start, pause_on_exit).then((port) async {
+ process.launch(pause_on_exit).then((port) async {
if (mainArgs.contains("--gdb")) {
port = 8181;
}
« no previous file with comments | « runtime/observatory/tests/service/pause_on_start_then_step_test.dart ('k') | runtime/vm/debugger.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698