Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1286483003: Devtools UI: Update inspect element node description label UI (Closed)

Created:
5 years, 4 months ago by samli
Modified:
5 years, 4 months ago
Reviewers:
pfeldman
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, sergeyv+blink_chromium.org, yurys+blink_chromium.org, maxwalker, paulirish
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Devtools UI: Update inspect element node description label UI This change updates the node description label to match updated tooltip UI. These labels have the following characteristics: - Default to above the anchor element - Centered above the anchor element - Clamped to the visible viewport (no change) - Non monospace font to improve text readibility - Removal of "px" in dimensions This change is behind the material experiment. BUG=513066 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200622

Patch Set 1 #

Patch Set 2 : Rebase tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+202 lines, -19 lines) Patch
M LayoutTests/inspector/elements/highlight/highlight-css-shapes-outside-expected.txt View 1 7 chunks +14 lines, -7 lines 0 comments Download
M LayoutTests/inspector/elements/highlight/highlight-css-shapes-outside-scroll-expected.txt View 1 2 chunks +4 lines, -2 lines 0 comments Download
M LayoutTests/inspector/elements/highlight/highlight-node-expected.txt View 1 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/inspector/elements/highlight/highlight-node-scaled-and-scrolled-expected.txt View 1 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/inspector/elements/highlight/highlight-node-scaled-expected.txt View 1 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/inspector/elements/highlight/highlight-node-scroll-expected.txt View 1 2 chunks +4 lines, -2 lines 0 comments Download
M LayoutTests/inspector/elements/highlight/highlight-node-transformed-expected.txt View 1 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/inspector/elements/highlight/highlight-svg-content-inside-iframe-expected.txt View 1 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/inspector/elements/highlight/highlight-svg-root-expected.txt View 1 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/inspector/elements/highlight/highlight-svg-root-zoomed-expected.txt View 1 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/inspector/InspectorDOMAgent.cpp View 1 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/inspector/InspectorHighlight.h View 1 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/inspector/InspectorHighlight.cpp View 1 5 chunks +5 lines, -0 lines 0 comments Download
M Source/core/inspector/InspectorOverlayPage.html View 1 5 chunks +154 lines, -1 line 0 comments Download
M Source/devtools/front_end/sdk/DOMModel.js View 1 chunk +1 line, -0 lines 0 comments Download
M Source/devtools/protocol.json View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
samli
CC: paul, max Screenshot: http://i.imgur.com/5O7XVsr.png This change is the same as https://codereview.chromium.org/1255573004 except now behind ...
5 years, 4 months ago (2015-08-11 04:58:07 UTC) #2
pfeldman
lgtm
5 years, 4 months ago (2015-08-11 05:39:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1286483003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1286483003/1
5 years, 4 months ago (2015-08-11 06:59:59 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/65739)
5 years, 4 months ago (2015-08-11 08:10:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1286483003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1286483003/20001
5 years, 4 months ago (2015-08-17 00:30:53 UTC) #10
commit-bot: I haz the power
5 years, 4 months ago (2015-08-17 02:38:35 UTC) #11
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200622

Powered by Google App Engine
This is Rietveld 408576698