Issue 1286383006: Fix port of CrashReportUploadThread to windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1286383006: Fix port of CrashReportUploadThread to windows (Closed)

Created:
5 years, 4 months ago by scottmg

Modified:
5 years, 4 months ago

Reviewers:
Mark Mentovai

CC:
crashpad-dev_chromium.org, mihnea_arkaos.net

Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master

Target Ref:
refs/heads/master

Project:
crashpad

Visibility:
Public.

Fix port of CrashReportUploadThread to windows util/thread/ doesn't automatically start, contrary to previous pthread implementation. Thanks to mihnea@arkaos.net for the patch. R=mark@chromium.org BUG=https://codereview.chromium.org/1295363002/#msg5 Committed: https://chromium.googlesource.com/crashpad/crashpad/+/4f2d2018de3d898529d7f3ce2bfdf11eb7b543c2

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	handler/crash_report_upload_thread.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

scottmg

5 years, 4 months ago (2015-08-19 16:41:57 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
4f2d2018de3d898529d7f3ce2bfdf11eb7b543c2 (presubmit successful).