net/proxy/proxy_list.h - Issue 1286373002: Refactored not to expose raw pointers on ProxyList class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/proxy/proxy_list.h

Issue 1286373002: Refactored not to expose raw pointers on ProxyList class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/proxy/proxy_list.h

diff --git a/net/proxy/proxy_list.h b/net/proxy/proxy_list.h

index aa477d2083834fd7cf5d1bb3c305c600c5926931..97e0af65ee149f08a1ed50361588d38e2d55d84e 100644

--- a/net/proxy/proxy_list.h

+++ b/net/proxy/proxy_list.h

@@ -78,8 +78,8 @@ class NET_EXPORT_PRIVATE ProxyList {

// For example: "PROXY xxx.xxx.xxx.xxx:xx; SOCKS yyy.yyy.yyy:yy".

std::string ToPacString() const;

- // Returns a serialized value for the list. The caller takes ownership of it.

- base::ListValue* ToValue() const;

+ // Returns a serialized value for the list.

+ scoped_ptr<base::ListValue> ToValue() const;

// Marks the current proxy server as bad and deletes it from the list. The

// list of known bad proxies is given by |proxy_retry_info|. |net_error|

« no previous file with comments | « AUTHORS ('k') | net/proxy/proxy_list.cc » ('j') | no next file with comments »