Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 1286363002: Switch media stream permissions to use IsOriginSecure() instead of SchemeIsSecure(). (Closed)

Created:
5 years, 4 months ago by lgarron
Modified:
5 years, 4 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, mcasas+watch_chromium.org, phoglund+watch_chromium.org, posciak+watch_chromium.org, tnakamura+watch_chromium.org, wjia+watch_chromium.org, palmer
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Switch media stream permissions to use IsOriginSecure() instead of SchemeIsSecure(). In particular, note that this means that media permissions are persisted on http://localhost . The change also updates the old media stream permission tests (which were no longer testing anything meaningful). (This is a reland of https://codereview.chromium.org/1276373004/ with a fixed test, after it was reverted in https://codereview.chromium.org/1276373004/ ) BUG=295723, 362214, 509844 Committed: https://crrev.com/64d923cbb60f7ac1d7d21e63224b8120bd323f1c Cr-Commit-Position: refs/heads/master@{#343276}

Patch Set 1 : Copy of patch #11 from the original CL. #

Patch Set 2 : Fix test. #

Total comments: 5

Patch Set 3 : Address nits. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+192 lines, -39 lines) Patch
M chrome/browser/media/chrome_media_stream_infobar_browsertest.cc View 1 2 7 chunks +65 lines, -24 lines 0 comments Download
M chrome/browser/media/chrome_webrtc_webcam_browsertest.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/media/desktop_capture_access_handler.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/media/media_stream_device_permissions.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M chrome/browser/media/media_stream_devices_controller.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/media/media_stream_infobar_delegate.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/media/webrtc_browsertest_base.h View 1 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/browser/media/webrtc_browsertest_base.cc View 1 2 5 chunks +104 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
lgarron
tommi@: Would you mind re-reviewing this? I introduced a new test function GetUserMediaWithSpecificConstraintsAndAcceptIfPrompted() and used ...
5 years, 4 months ago (2015-08-13 06:03:34 UTC) #3
tommi (sloooow) - chröme
lgtm https://codereview.chromium.org/1286363002/diff/40001/chrome/browser/media/chrome_media_stream_infobar_browsertest.cc File chrome/browser/media/chrome_media_stream_infobar_browsertest.cc (right): https://codereview.chromium.org/1286363002/diff/40001/chrome/browser/media/chrome_media_stream_infobar_browsertest.cc#newcode37 chrome/browser/media/chrome_media_stream_infobar_browsertest.cc:37: MediaStreamPermissionTest() : use_secure_origin_for_test_page_(true) {} fyi - could use ...
5 years, 4 months ago (2015-08-13 13:03:17 UTC) #4
lgarron
https://codereview.chromium.org/1286363002/diff/40001/chrome/browser/media/chrome_media_stream_infobar_browsertest.cc File chrome/browser/media/chrome_media_stream_infobar_browsertest.cc (right): https://codereview.chromium.org/1286363002/diff/40001/chrome/browser/media/chrome_media_stream_infobar_browsertest.cc#newcode37 chrome/browser/media/chrome_media_stream_infobar_browsertest.cc:37: MediaStreamPermissionTest() : use_secure_origin_for_test_page_(true) {} On 2015/08/13 at 13:03:17, tommi ...
5 years, 4 months ago (2015-08-13 20:30:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1286363002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1286363002/60001
5 years, 4 months ago (2015-08-13 20:30:39 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:60001)
5 years, 4 months ago (2015-08-13 21:28:32 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-08-13 21:29:11 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/64d923cbb60f7ac1d7d21e63224b8120bd323f1c
Cr-Commit-Position: refs/heads/master@{#343276}

Powered by Google App Engine
This is Rietveld 408576698