Switch media stream permissions to use IsOriginSecure() instead of SchemeIsSecure().

Switch media stream permissions to use IsOriginSecure() instead of SchemeIsSecure().

In particular, note that this means that media permissions are persisted on
http://localhost .

The change also updates the old media stream permission tests (which
were no longer testing anything meaningful).

(This is a reland of https://codereview.chromium.org/1276373004/ with a fixed
test, after it was reverted in https://codereview.chromium.org/1276373004/ )

BUG=295723, 362214, 509844
Committed: https://crrev.com/64d923cbb60f7ac1d7d21e63224b8120bd323f1c
Cr-Commit-Position: refs/heads/master@{#343276}

[lgarron, 2015-08-13 05:58:34]

Patchset #1 (id:1) has been deleted

[lgarron, 2015-08-13 06:03:33]

lgarron@chromium.org changed reviewers:
+ felt@chromium.org, tommi@chromium.org

[lgarron, 2015-08-13 06:03:34]

tommi@: Would you mind re-reviewing this?

I introduced a new test function
GetUserMediaWithSpecificConstraintsAndAcceptIfPrompted() and used it in the
relevant test.

[tommi (sloooow) - chröme, 2015-08-13 13:03:17]

lgtm

https://codereview.chromium.org/1286363002/diff/40001/chrome/browser/media/ch...
File chrome/browser/media/chrome_media_stream_infobar_browsertest.cc (right):

https://codereview.chromium.org/1286363002/diff/40001/chrome/browser/media/ch...
chrome/browser/media/chrome_media_stream_infobar_browsertest.cc:37:
MediaStreamPermissionTest() : use_secure_origin_for_test_page_(true) {}
fyi - could use in-class initialization

https://codereview.chromium.org/1286363002/diff/40001/chrome/browser/media/ch...
File chrome/browser/media/chrome_webrtc_webcam_browsertest.cc (right):

https://codereview.chromium.org/1286363002/diff/40001/chrome/browser/media/ch...
chrome/browser/media/chrome_webrtc_webcam_browsertest.cc:59: if
(GetUserMediaWithSpecificConstraintsAndAcceptIfPrompted(tab, constraints)) {
is this still within 80? (just checking)

https://codereview.chromium.org/1286363002/diff/40001/chrome/browser/media/we...
File chrome/browser/media/webrtc_browsertest_base.cc (right):

https://codereview.chromium.org/1286363002/diff/40001/chrome/browser/media/we...
chrome/browser/media/webrtc_browsertest_base.cc:99: bool request_shown() {
return request_shown_; }
nit: const?

[lgarron, 2015-08-13 20:30:01]

https://codereview.chromium.org/1286363002/diff/40001/chrome/browser/media/ch...
File chrome/browser/media/chrome_media_stream_infobar_browsertest.cc (right):

https://codereview.chromium.org/1286363002/diff/40001/chrome/browser/media/ch...
chrome/browser/media/chrome_media_stream_infobar_browsertest.cc:37:
MediaStreamPermissionTest() : use_secure_origin_for_test_page_(true) {}
On 2015/08/13 at 13:03:17, tommi wrote:
> fyi - could use in-class initialization

:-D

https://codereview.chromium.org/1286363002/diff/40001/chrome/browser/media/ch...
File chrome/browser/media/chrome_webrtc_webcam_browsertest.cc (right):

https://codereview.chromium.org/1286363002/diff/40001/chrome/browser/media/ch...
chrome/browser/media/chrome_webrtc_webcam_browsertest.cc:59: if
(GetUserMediaWithSpecificConstraintsAndAcceptIfPrompted(tab, constraints)) {
On 2015/08/13 at 13:03:17, tommi wrote:
> is this still within 80? (just checking)

Good catch!
It seems I forgot to run `git cl format`. :-(

[lgarron, 2015-08-13 20:30:12]

The CQ bit was checked by lgarron@chromium.org

[lgarron, 2015-08-13 20:30:12]

The patchset sent to the CQ was uploaded after l-g-t-m from tommi@chromium.org
Link to the patchset: https://codereview.chromium.org/1286363002/#ps60001
(title: "Address nits.")

[commit-bot: I haz the power, 2015-08-13 20:30:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1286363002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1286363002/60001

[commit-bot: I haz the power, 2015-08-13 21:28:32]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2015-08-13 21:29:11]

Patchset 3 (id:??) landed as
https://crrev.com/64d923cbb60f7ac1d7d21e63224b8120bd323f1c
Cr-Commit-Position: refs/heads/master@{#343276}