Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Unified Diff: Source/core/inspector/PageDebuggerAgent.cpp

Issue 1286343003: DevTools: make InspectorDebuggerAgent aggregate V8DebuggerAgent instead of inheriting (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fixed presubmit errors Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/inspector/PageDebuggerAgent.cpp
diff --git a/Source/core/inspector/PageDebuggerAgent.cpp b/Source/core/inspector/PageDebuggerAgent.cpp
index 6b6aeb5df0b22feee33074baef72a0cd41a98ab3..0e1a653469d3fe515a1393617a141cc77cb367d7 100644
--- a/Source/core/inspector/PageDebuggerAgent.cpp
+++ b/Source/core/inspector/PageDebuggerAgent.cpp
@@ -136,7 +136,7 @@ void PageDebuggerAgent::overlaySteppedOver()
InjectedScript PageDebuggerAgent::defaultInjectedScript()
{
ScriptState* scriptState = ScriptState::forMainWorld(m_pageAgent->inspectedFrame());
- return injectedScriptManager()->injectedScriptFor(scriptState);
+ return m_debuggerAgent->injectedScriptManager()->injectedScriptFor(scriptState);
}
void PageDebuggerAgent::didStartProvisionalLoad(LocalFrame* frame)
@@ -152,17 +152,17 @@ void PageDebuggerAgent::didClearDocumentOfWindowObject(LocalFrame* frame)
// FIXME: what about nested objects?
if (frame != m_pageAgent->inspectedFrame())
return;
- reset();
+ m_debuggerAgent->reset();
}
void PageDebuggerAgent::didCommitLoadForLocalFrame(LocalFrame*)
{
- resetModifiedSources();
+ m_debuggerAgent->resetModifiedSources();
}
void PageDebuggerAgent::compileScript(ErrorString* errorString, const String& expression, const String& sourceURL, bool persistScript, const int* executionContextId, TypeBuilder::OptOutput<ScriptId>* scriptId, RefPtr<ExceptionDetails>& exceptionDetails)
{
- InjectedScript injectedScript = injectedScriptForEval(errorString, executionContextId);
+ InjectedScript injectedScript = m_debuggerAgent->injectedScriptForEval(errorString, executionContextId);
if (injectedScript.isEmpty()) {
*errorString = "Inspected frame has gone";
return;
@@ -180,7 +180,7 @@ void PageDebuggerAgent::compileScript(ErrorString* errorString, const String& ex
void PageDebuggerAgent::runScript(ErrorString* errorString, const ScriptId& scriptId, const int* executionContextId, const String* const objectGroup, const bool* const doNotPauseOnExceptionsAndMuteConsole, RefPtr<RemoteObject>& result, RefPtr<ExceptionDetails>& exceptionDetails)
{
- InjectedScript injectedScript = injectedScriptForEval(errorString, executionContextId);
+ InjectedScript injectedScript = m_debuggerAgent->injectedScriptForEval(errorString, executionContextId);
if (injectedScript.isEmpty()) {
*errorString = "Inspected frame has gone";
return;
@@ -192,7 +192,7 @@ void PageDebuggerAgent::runScript(ErrorString* errorString, const ScriptId& scri
TRACE_EVENT1("devtools.timeline", "EvaluateScript", "data", InspectorEvaluateScriptEvent::data(frame, sourceURL, TextPosition::minimumPosition().m_line.oneBasedInt()));
InspectorInstrumentationCookie cookie;
if (frame)
- cookie = InspectorInstrumentation::willEvaluateScript(frame, sourceURL, TextPosition::minimumPosition().m_line.oneBasedInt());
+ cookie = InspectorInstrumentation::willEvaluateScript(frame);
RefPtrWillBeRawPtr<LocalFrame> protect(frame);
InspectorDebuggerAgent::runScript(errorString, scriptId, executionContextId, objectGroup, doNotPauseOnExceptionsAndMuteConsole, result, exceptionDetails);

Powered by Google App Engine
This is Rietveld 408576698