Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 1286343002: MIPS64: Fix InterpreterEntryTrampoline(). (Closed)

Created:
5 years, 4 months ago by paul.l...
Modified:
5 years, 4 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS64: Fix InterpreterEntryTrampoline(). Was incorrectly loading BytecodeArray::kFrameSizeOffset as 64-bit int. TEST=cctest/test-interpreter/TestInterpreterReturn BUG= Committed: https://crrev.com/567e2c63a1d166a3b7e82527a0bd45ab037c34d5 Cr-Commit-Position: refs/heads/master@{#30159}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/mips64/builtins-mips64.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
paul.l...
Fix a mistake in my porting of https://codereview.chromium.org/1245133002 for mips. PTAL.
5 years, 4 months ago (2015-08-13 04:38:58 UTC) #2
rmcilroy
On 2015/08/13 04:38:58, paul.l... wrote: > Fix a mistake in my porting of https://codereview.chromium.org/1245133002 for ...
5 years, 4 months ago (2015-08-13 06:23:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1286343002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1286343002/1
5 years, 4 months ago (2015-08-13 14:02:37 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-13 14:27:09 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-13 14:27:23 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/567e2c63a1d166a3b7e82527a0bd45ab037c34d5
Cr-Commit-Position: refs/heads/master@{#30159}

Powered by Google App Engine
This is Rietveld 408576698