Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 1286313003: X87: [simd.js] Single SIMD128_VALUE_TYPE for all Simd128Values. (Closed)

Created:
5 years, 4 months ago by chunyang.dai
Modified:
5 years, 4 months ago
Reviewers:
Weiliang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [simd.js] Single SIMD128_VALUE_TYPE for all Simd128Values. port f4c079d450a5990639b295d40a3d1663d70412d6 (r30107). original commit message: There's no need to have one InstanceType per SIMD primitive type (this will not scale long-term). Also reduce the amount of code duplication and make it more robust wrt adding new SIMD types. BUG= Committed: https://crrev.com/b46f0e9f468dd69b79807790070290a55c49b29e Cr-Commit-Position: refs/heads/master@{#30241}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -40 lines) Patch
M src/full-codegen/x87/full-codegen-x87.cc View 3 chunks +12 lines, -34 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 2 chunks +2 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL
5 years, 4 months ago (2015-08-13 06:28:56 UTC) #2
Weiliang
lgtm
5 years, 4 months ago (2015-08-19 02:54:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1286313003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1286313003/1
5 years, 4 months ago (2015-08-19 02:54:33 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-19 03:18:54 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-19 03:19:06 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b46f0e9f468dd69b79807790070290a55c49b29e
Cr-Commit-Position: refs/heads/master@{#30241}

Powered by Google App Engine
This is Rietveld 408576698