Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 12863: Changed the Browser::Reload() function to check the url... (Closed)

Created:
12 years ago by kingofcamelot
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Changed the Browser::Reload() function to check the url of the tab being reloaded, and if it is a valid url then to send it to the address bar upon reload. This way if you delete the address and reload the page, the url appears in the address bar again. BUG=2985

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -1 line) Patch
M chrome/browser/browser.cc View 3 chunks +18 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
kingofcamelot
12 years ago (2008-12-02 09:49:55 UTC) #1
Peter Kasting
Thanks for the patch, but I don't think this is the right way to fix ...
12 years ago (2008-12-02 18:06:56 UTC) #2
kingofcamelot
Could you expand a little on the other times this bug occurs, like the "open ...
12 years ago (2008-12-02 21:30:32 UTC) #3
Peter Kasting
12 years ago (2008-12-02 21:54:43 UTC) #4
On 2008/12/02 21:30:32, kingofcamelot wrote:
> Could you expand a little on the other times this bug occurs, like the "open
> file" command you mention?

Any time you edit the URL and then make some explicit action that changes it
without changing focus, e.g. hitting reload, back, forward, ctrl-o and opening a
file, etc., the bug occurs.

Powered by Google App Engine
This is Rietveld 408576698