Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issue 1286273002: Address Win/Clang style plugin error in hwnd_message_handler.h (Closed)

Created:
5 years, 4 months ago by hans
Modified:
5 years, 4 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Address Win/Clang style plugin error in hwnd_message_handler.h This should fix the error below, and also make the code adhere to the comment in the header: "The WeakPtrFactories below must occur last" :-) In file included from ..\..\ui\views\win\hwnd_message_handler.cc:5: ..\..\ui/views/win/hwnd_message_handler.h(594,44) : error: [chromium-style] WeakPtrFactory members which refer to their outer class must be the last member in the outer class definition. base::WeakPtrFactory<HWNDMessageHandler> autohide_factory_; ^ BUG=82385 TBR=sky Committed: https://crrev.com/49bac10701d666cd09a9a636ed599ece997fe330 Cr-Commit-Position: refs/heads/master@{#343096}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M ui/views/win/hwnd_message_handler.h View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
hans
Please take a look.
5 years, 4 months ago (2015-08-12 20:30:03 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1286273002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1286273002/1
5 years, 4 months ago (2015-08-12 20:30:45 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-12 21:13:02 UTC) #6
hans
tbr'ing to hopefully get the bots green today.
5 years, 4 months ago (2015-08-12 21:18:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1286273002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1286273002/1
5 years, 4 months ago (2015-08-12 21:18:59 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-12 21:24:11 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/49bac10701d666cd09a9a636ed599ece997fe330 Cr-Commit-Position: refs/heads/master@{#343096}
5 years, 4 months ago (2015-08-12 21:25:05 UTC) #11
sky
5 years, 4 months ago (2015-08-12 23:41:13 UTC) #12
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698