IPC: Add attachment brokering support to the message header.

ipc/ipc_channel_win.cc

Index: ipc/ipc_channel_win.cc
diff --git a/ipc/ipc_channel_win.cc b/ipc/ipc_channel_win.cc
index 1442f7fab7b095392510dbe6509c618c49cbffbc..84ee92c092f6df784e1f67270232f63e404e5489 100644
--- a/ipc/ipc_channel_win.cc
+++ b/ipc/ipc_channel_win.cc
@@ -53,6 +53,7 @@ ChannelWin::ChannelWin(const IPC::ChannelHandle& channel_handle,
 }
 
 ChannelWin::~ChannelWin() {
+  CleanUp();
   Close();
 }
 
@@ -74,9 +75,9 @@ void ChannelWin::Close() {
   }
 
   while (!output_queue_.empty()) {
-    Message* m = output_queue_.front();
+    OutputElement* element = output_queue_.front();
     output_queue_.pop();
-    delete m;
+    delete element;
   }
 }
 
@@ -123,7 +124,19 @@ bool ChannelWin::ProcessMessageForDelivery(Message* message) {
   message->TraceMessageBegin();
 
   // |output_queue_| takes ownership of |message|.
-  output_queue_.push(message);
+  OutputElement* element = new OutputElement(message);
+  output_queue_.push(element);
+
+#if USE_ATTACHMENT_BROKER
+  if (message->HasBrokerableAttachments()) {
+    // |output_queue_| takes ownership of |ids.buffer|.
+    Message::SerializedAttachmentIds ids =
+        message->SerializedIdsOfBrokerableAttachments();
+    OutputElement* element2 = new OutputElement(ids.buffer, ids.size);

[Tom Sepez, 2015/08/17 18:29:39]

nit: maybe call this new_element rather than element2

[erikchen, 2015/08/18 05:59:46]

Done.

+    output_queue_.push(element2);
+  }
+#endif
+
   // ensure waiting to write
   if (!waiting_connect_) {
     if (!output_state_.is_pending) {
@@ -360,7 +373,8 @@ bool ChannelWin::CreatePipe(const IPC::ChannelHandle &channel_handle,
     return false;
   }
 
-  output_queue_.push(m.release());
+  OutputElement* element = new OutputElement(m.release());
+  output_queue_.push(element);
   return true;
 }
 
@@ -450,9 +464,9 @@ bool ChannelWin::ProcessOutgoingMessages(
     }
     // Message was sent.
     CHECK(!output_queue_.empty());
-    Message* m = output_queue_.front();
+    OutputElement* element = output_queue_.front();
     output_queue_.pop();
-    delete m;
+    delete element;
   }
 
   if (output_queue_.empty())
@@ -462,20 +476,21 @@ bool ChannelWin::ProcessOutgoingMessages(
     return false;
 
   // Write to pipe...
-  Message* m = output_queue_.front();
-  DCHECK(m->size() <= INT_MAX);
-  BOOL ok = WriteFile(pipe_.Get(),
-                      m->data(),
-                      static_cast<uint32>(m->size()),
-                      NULL,
+  OutputElement* element = output_queue_.front();
+  DCHECK(element->size() <= INT_MAX);
+  BOOL ok = WriteFile(pipe_.Get(), element->data(),
+                      static_cast<uint32>(element->size()), NULL,
                       &output_state_.context.overlapped);
   if (!ok) {
     DWORD write_error = GetLastError();
     if (write_error == ERROR_IO_PENDING) {
       output_state_.is_pending = true;
 
-      DVLOG(2) << "sent pending message @" << m << " on channel @" << this
-               << " with type " << m->type();
+      Message* m = element->get_message();
+      if (m) {
+        DVLOG(2) << "sent pending message @" << m << " on channel @" << this
+                 << " with type " << m->type();
+      }
 
       return true;
     }
@@ -483,8 +498,11 @@ bool ChannelWin::ProcessOutgoingMessages(
     return false;
   }
 
-  DVLOG(2) << "sent message @" << m << " on channel @" << this
-           << " with type " << m->type();
+  Message* m = element->get_message();
+  if (m) {
+    DVLOG(2) << "sent message @" << m << " on channel @" << this
+             << " with type " << m->type();
+  }
 
   output_state_.is_pending = true;
   return true;