Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Issue 1286233004: Revert of Fix the mechanism by which Blink determines OSX version number. (Closed)

Created:
5 years, 4 months ago by tkent
Modified:
5 years, 4 months ago
Reviewers:
erikchen, Nico
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Fix the mechanism by which Blink determines OSX version number. (patchset #4 id:60001 of https://codereview.chromium.org/1301693002/ ) Reason for revert: VersionUtilMac.AppKitVersions fails on OSX 10.6 and 10.7. http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=blink_platform_unittests&showExpectations=true&tests=VersionUtilMac.AppKitVersions Original issue's description: > Fix the mechanism by which Blink determines OSX version number. > > Previously, Blink was checking NSAppKitVersionNumber against a compile time > constant. This mechanism doesn't work (see the bug for more details). This CL > converts the logic to use the same mechanism that Chromium uses. > > BUG=521034 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200708 TBR=thakis@chromium.org,erikchen@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=521034 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200711

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -128 lines) Patch
M Source/platform/blink_platform.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/mac/ThemeMac.mm View 2 chunks +9 lines, -3 lines 0 comments Download
M Source/platform/mac/VersionUtilMac.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/platform/mac/VersionUtilMac.mm View 1 chunk +6 lines, -64 lines 0 comments Download
D Source/platform/mac/VersionUtilMacTest.mm View 1 chunk +0 lines, -57 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
tkent
Created Revert of Fix the mechanism by which Blink determines OSX version number.
5 years, 4 months ago (2015-08-18 07:39:53 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1286233004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1286233004/1
5 years, 4 months ago (2015-08-18 07:39:58 UTC) #2
commit-bot: I haz the power
5 years, 4 months ago (2015-08-18 07:40:21 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200711

Powered by Google App Engine
This is Rietveld 408576698