Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 128623003: IndexedDB: Don't reset cursor prefetches on non-transactional calls (Closed)

Created:
6 years, 11 months ago by jsbell
Modified:
6 years, 11 months ago
Reviewers:
dgrogan
CC:
chromium-reviews, jsbell, jam, alecflett, joi+watch-content_chromium.org, darin-cc_chromium.org, cmumford, dgrogan
Visibility:
Public.

Description

IndexedDB: Don't reset cursor prefetches on non-transactional calls Cursor prefetch caches must be reset when requests that could invalidate the cache are made (i.e. puts, deletes), and to ensure that requests are processed in order per spec (i.e. even gets). This doesn't apply to requests that aren't scoped to a transaction, so some unnecessary resets can be removed. BUG=329950 R=dgrogan Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243737

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M content/child/indexed_db/indexed_db_dispatcher.cc View 5 chunks +1 line, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jsbell
dgrogan@ - PTAL? I didn't include tests since they'd be complex and contrived, and just ...
6 years, 11 months ago (2014-01-08 19:53:33 UTC) #1
dgrogan
lgtm
6 years, 11 months ago (2014-01-08 22:14:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jsbell@chromium.org/128623003/1
6 years, 11 months ago (2014-01-08 22:24:57 UTC) #3
commit-bot: I haz the power
6 years, 11 months ago (2014-01-09 01:49:25 UTC) #4
Message was sent while issue was closed.
Change committed as 243737

Powered by Google App Engine
This is Rietveld 408576698