Fail early in GrPipeline::CreateAt() if XP creation fails

Fail early in GrPipeline::CreateAt() if XP creation fails

R=egdaniel@google.com

Committed: https://skia.googlesource.com/skia/+/c8d3f577aedda087529e25bc48bc64769e410f5a

[bsalomon, 2015-08-12 20:06:31]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2015-08-12 20:06:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1286173006/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1286173006/1

[commit-bot: I haz the power, 2015-08-12 20:06:43]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2015-08-13 02:06 UTC

[egdaniel, 2015-08-12 20:37:17]

The CQ bit was unchecked by egdaniel@google.com

[egdaniel, 2015-08-12 20:37:29]

lgtm with one nit

https://codereview.chromium.org/1286173006/diff/1/src/gpu/GrPipeline.cpp
File src/gpu/GrPipeline.cpp (right):

https://codereview.chromium.org/1286173006/diff/1/src/gpu/GrPipeline.cpp#newc...
src/gpu/GrPipeline.cpp:45: if (SkToBool(GrXferProcessor::kIgnoreColor_OptFlag &
optFlags)) {
lets move this check bellow the return nullptr below

[bsalomon, 2015-08-13 13:36:56]

The CQ bit was checked by bsalomon@google.com

[bsalomon, 2015-08-13 13:36:57]

The patchset sent to the CQ was uploaded after l-g-t-m from egdaniel@google.com
Link to the patchset: https://codereview.chromium.org/1286173006/#ps20001
(title: "Address comment")

[commit-bot: I haz the power, 2015-08-13 13:37:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1286173006/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1286173006/20001

[bsalomon, 2015-08-13 13:37:09]

https://codereview.chromium.org/1286173006/diff/1/src/gpu/GrPipeline.cpp
File src/gpu/GrPipeline.cpp (right):

https://codereview.chromium.org/1286173006/diff/1/src/gpu/GrPipeline.cpp#newc...
src/gpu/GrPipeline.cpp:45: if (SkToBool(GrXferProcessor::kIgnoreColor_OptFlag &
optFlags)) {
On 2015/08/12 20:37:29, egdaniel wrote:
> lets move this check bellow the return nullptr below

Done.

[commit-bot: I haz the power, 2015-08-13 13:44:08]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/c8d3f577aedda087529e25bc48bc64769e410f5a