Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(571)

Issue 1286143009: X87: Realize IWYU pattern for frames-inl.h header. (Closed)

Created:
5 years, 4 months ago by chunyang.dai
Modified:
5 years, 4 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Realize IWYU pattern for frames-inl.h header. port 19a49abf02dfac722dc8c5079aba9d73fcd60725 (r30127). original commit message: BUG= Committed: https://crrev.com/9fdbc1e25c8fb9a0a1b0e9fbb36c817b2d70d58d Cr-Commit-Position: refs/heads/master@{#30185}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M test/cctest/test-disasm-x87.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
chunyang.dai
PTAL
5 years, 4 months ago (2015-08-13 06:29:25 UTC) #2
Weiliang
lgtm
5 years, 4 months ago (2015-08-13 12:58:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1286143009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1286143009/1
5 years, 4 months ago (2015-08-13 12:58:15 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/4887)
5 years, 4 months ago (2015-08-13 13:03:20 UTC) #7
chunyang.dai
Hello. Michael. PTAL. This porting patch needs one review from the owner of this file. ...
5 years, 4 months ago (2015-08-14 02:18:16 UTC) #9
Michael Starzinger
LGTM. Thanks!
5 years, 4 months ago (2015-08-14 16:27:17 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1286143009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1286143009/1
5 years, 4 months ago (2015-08-17 00:15:50 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-17 00:40:34 UTC) #13
commit-bot: I haz the power
5 years, 4 months ago (2015-08-17 00:40:49 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9fdbc1e25c8fb9a0a1b0e9fbb36c817b2d70d58d
Cr-Commit-Position: refs/heads/master@{#30185}

Powered by Google App Engine
This is Rietveld 408576698