Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(674)

Issue 1286143002: Debugger: correctly ensure debug info in Debug::Break. (Closed)

Created:
5 years, 4 months ago by Yang
Modified:
5 years, 4 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Debugger: correctly ensure debug info in Debug::Break. R=bmeurer@chromium.org BUG=chromium:517594 LOG=N Committed: https://crrev.com/c1d20f831bea84f83973288bca02d959119f1504 Cr-Commit-Position: refs/heads/master@{#30124}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M src/debug/debug.cc View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Yang
5 years, 4 months ago (2015-08-12 07:02:20 UTC) #1
Benedikt Meurer
LGTM.
5 years, 4 months ago (2015-08-12 07:04:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1286143002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1286143002/20001
5 years, 4 months ago (2015-08-12 07:05:18 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-12 07:30:28 UTC) #5
commit-bot: I haz the power
5 years, 4 months ago (2015-08-12 07:30:52 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c1d20f831bea84f83973288bca02d959119f1504
Cr-Commit-Position: refs/heads/master@{#30124}

Powered by Google App Engine
This is Rietveld 408576698