Issue 1286133003: [es6] Remove redundant flag parameter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1286133003: [es6] Remove redundant flag parameter (Closed)

Created:
5 years, 4 months ago by rossberg

Modified:
5 years, 4 months ago

Reviewers:
adamk

CC:
v8-dev, caitp (gmail)

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

More Reviews

Description

[es6] Remove redundant flag parameter R=adamk@chromium.org BUG= Committed: https://crrev.com/0584903167c198042259f3236078e45ea3c26033 Cr-Commit-Position: refs/heads/master@{#30167}

Patch Set 1 #

Total comments: 1

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -11 lines)			Patch
	M	src/parser.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download
	M	src/preparser.h	View		4 chunks	+8 lines, -9 lines	1 comment	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

adamk

lgtm % nit https://codereview.chromium.org/1286133003/diff/1/src/preparser.h File src/preparser.h (right): https://codereview.chromium.org/1286133003/diff/1/src/preparser.h#newcode3644 src/preparser.h:3644: parameters->has_rest = is_rest; This line is ...

5 years, 4 months ago (2015-08-13 17:13:22 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1286133003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1286133003/1

5 years, 4 months ago (2015-08-13 18:10:20 UTC) #4

commit-bot: I haz the power

5 years, 4 months ago (2015-08-13 18:36:52 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/0584903167c198042259f3236078e45ea3c26033
Cr-Commit-Position: refs/heads/master@{#30167}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages