Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 1286133003: [es6] Remove redundant flag parameter (Closed)

Created:
5 years, 4 months ago by rossberg
Modified:
5 years, 4 months ago
Reviewers:
adamk
CC:
v8-dev, caitp (gmail)
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[es6] Remove redundant flag parameter R=adamk@chromium.org BUG= Committed: https://crrev.com/0584903167c198042259f3236078e45ea3c26033 Cr-Commit-Position: refs/heads/master@{#30167}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -11 lines) Patch
M src/parser.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/preparser.h View 4 chunks +8 lines, -9 lines 1 comment Download

Messages

Total messages: 6 (1 generated)
rossberg
5 years, 4 months ago (2015-08-13 10:59:36 UTC) #1
adamk
lgtm % nit https://codereview.chromium.org/1286133003/diff/1/src/preparser.h File src/preparser.h (right): https://codereview.chromium.org/1286133003/diff/1/src/preparser.h#newcode3644 src/preparser.h:3644: parameters->has_rest = is_rest; This line is ...
5 years, 4 months ago (2015-08-13 17:13:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1286133003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1286133003/1
5 years, 4 months ago (2015-08-13 18:10:20 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-13 18:36:40 UTC) #5
commit-bot: I haz the power
5 years, 4 months ago (2015-08-13 18:36:52 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0584903167c198042259f3236078e45ea3c26033
Cr-Commit-Position: refs/heads/master@{#30167}

Powered by Google App Engine
This is Rietveld 408576698