Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 12861002: drive: Remove "/-/mine" from WAPI resource list urls. (Closed)

Created:
7 years, 9 months ago by kinaba
Modified:
7 years, 9 months ago
Reviewers:
Haruki Sato
CC:
chromium-reviews, achuith+watch_chromium.org, tzik
Visibility:
Public.

Description

drive: Remove "/-/mine" from WAPI resource list urls. By this change, files owned by others but included in the "My Drive" hierarchy of the authenticated user will become shown in the File Manager of Chrome OS. Typical use case of the situation is exlained below in the testing steps. BUG=176115, 189087 TEST=Verify the following manual steps work. 1. Log in to drive.google.com with account X and create a folder under My Drive. 2. Share the folder to another account Y. 3. Upload a file to the folder from Y. 4. Open Files.app of ChromeOS in the account X. 5. Ctrl-click the geer menu, clean local cache. Wait for re-fetching. 6. The file uploaded at the step 3 should show up in the folder. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=188286

Patch Set 1 #

Patch Set 2 : Modified the test feed to include an not-mine entry. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -27 lines) Patch
M chrome/browser/chromeos/drive/drive_file_system_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/google_apis/fake_drive_service_unittest.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/google_apis/gdata_wapi_operations_unittest.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/google_apis/gdata_wapi_url_generator.cc View 1 2 chunks +4 lines, -14 lines 0 comments Download
M chrome/browser/google_apis/gdata_wapi_url_generator_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/test/data/chromeos/gdata/root_feed.json View 1 1 chunk +88 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
kinaba
haruki: this is the first half of the work including shared files in the feeds. ...
7 years, 9 months ago (2013-03-14 02:07:44 UTC) #1
Haruki Sato
Thank you for the change! Could you also check testcase JSONs in /chrome/test/data/chromeos/gdata/ and update ...
7 years, 9 months ago (2013-03-14 09:15:23 UTC) #2
Haruki Sato
lgtm
7 years, 9 months ago (2013-03-14 09:15:28 UTC) #3
kinaba
On 2013/03/14 09:15:23, Haruki Sato wrote: > Thank you for the change! > Could you ...
7 years, 9 months ago (2013-03-15 06:50:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/12861002/6001
7 years, 9 months ago (2013-03-15 06:51:41 UTC) #5
kinaba
7 years, 9 months ago (2013-03-15 07:36:00 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r188286 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698