Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Unified Diff: LayoutTests/svg/custom/js-late-pattern-and-object-creation.svg

Issue 1286093008: Replace setTimeout() with runAfterLayoutAndPaint() in a few tests (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | LayoutTests/svg/custom/resource-client-removal.svg » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: LayoutTests/svg/custom/js-late-pattern-and-object-creation.svg
diff --git a/LayoutTests/svg/custom/js-late-pattern-and-object-creation.svg b/LayoutTests/svg/custom/js-late-pattern-and-object-creation.svg
index c21c2dc6a0deeac09743d0d21e678bc763965c93..7b1e447ce881078680f1a18974b6a49a578be596 100644
--- a/LayoutTests/svg/custom/js-late-pattern-and-object-creation.svg
+++ b/LayoutTests/svg/custom/js-late-pattern-and-object-creation.svg
@@ -1,6 +1,7 @@
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE svg PUBLIC "-//W3C//DTD SVG 1.1 Basic//EN" "http://www.w3.org/Graphics/SVG/1.1/DTD/svg11-basic.dtd">
<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" id="svg-root" width="100%" height="100%" viewBox="0 0 480 360" onload="runRepaintAndPixelTest()">
+<script xlink:href="../../resources/run-after-layout-and-paint.js"/>
<script xlink:href="../../fast/repaint/resources/text-based-repaint.js"/>
<g id="content"/>
@@ -9,8 +10,7 @@
var content = document.getElementById("content");
function repaintTest() {
- // FIXME: we need a better way of waiting for layout/repainting to happen
- setTimeout(createPatterns, 1);
+ runAfterLayoutAndPaint(createPatterns);
}
function createPatterns()
@@ -71,8 +71,7 @@
content.appendChild(pattern2);
- // FIXME: we need a better way of waiting for layout/repainting to happen
- setTimeout(setupPatternUsers, 1);
+ runAfterLayoutAndPaint(setupPatternUsers);
}
function setupPatternUsers()
« no previous file with comments | « no previous file | LayoutTests/svg/custom/resource-client-removal.svg » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698