Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1650)

Unified Diff: components/omnibox/browser/scored_history_match.cc

Issue 1286093006: Launch HQP & HUP score changes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing Peters comments Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/omnibox/browser/scored_history_match.cc
diff --git a/components/omnibox/browser/scored_history_match.cc b/components/omnibox/browser/scored_history_match.cc
index 0c058d6af9771d2250169ba573c4d335eaf18c4b..794f5b935e51982a0b54e67ffc3b16656fc0f539 100644
--- a/components/omnibox/browser/scored_history_match.cc
+++ b/components/omnibox/browser/scored_history_match.cc
@@ -112,7 +112,12 @@ bool ScoredHistoryMatch::allow_tld_matches_ = false;
bool ScoredHistoryMatch::allow_scheme_matches_ = false;
size_t ScoredHistoryMatch::num_title_words_to_allow_ = 10u;
bool ScoredHistoryMatch::hqp_experimental_scoring_enabled_ = false;
-float ScoredHistoryMatch::topicality_threshold_ = -1;
+float ScoredHistoryMatch::topicality_threshold_ = 0.8;
+// Default HQP relevance buckets. URLs with relevance score > 20.0
+// are capped at 1399, score > 15 capped at 1300 etc. See
+// GetFinalRelevancyScore() for more details.
Peter Kasting 2015/08/27 19:21:40 Again, I'm not so much interested in a comment res
Ashok vardhan 2015/08/27 19:51:38 Done.
+char ScoredHistoryMatch::hqp_relevance_buckets_str_[] =
+ "0.0:400,1.5:600,5.0:900,10.5:1203,15.0:1300,20.0:1399";
std::vector<ScoredHistoryMatch::ScoreMaxRelevance>*
ScoredHistoryMatch::hqp_relevance_buckets_ = nullptr;
@@ -540,8 +545,7 @@ float ScoredHistoryMatch::GetTopicalityScore(
const float final_topicality_score = topicality_score / num_terms;
// Demote the URL if the topicality score is less than threshold.
- if (hqp_experimental_scoring_enabled_ &&
- (final_topicality_score < topicality_threshold_)) {
+ if (final_topicality_score < topicality_threshold_) {
return 0.0;
}
@@ -645,7 +649,8 @@ float ScoredHistoryMatch::GetFinalRelevancyScore(
void ScoredHistoryMatch::InitHQPExperimentalParams() {
// These are default HQP relevance scoring buckets.
// See GetFinalRelevancyScore() for details.
- std::string hqp_relevance_buckets_str = "0.0:400,1.5:600,12.0:1300,20.0:1399";
+ std::string hqp_relevance_buckets_str = std::string(
+ hqp_relevance_buckets_str_);
// Fetch the experiment params if they are any.
hqp_experimental_scoring_enabled_ =

Powered by Google App Engine
This is Rietveld 408576698