Launch HQP & HUP score changes.

components/omnibox/browser/omnibox_field_trial_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/omnibox/browser/omnibox_field_trial.h"
 
 #include "base/basictypes.h"
 #include "base/command_line.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/metrics/field_trial.h"
@@ skipping 428 matching lines @@
             scoring_params.typed_count_buckets.buckets()[2]);
   EXPECT_EQ(11, scoring_params.visited_count_buckets.relevance_cap());
   EXPECT_EQ(31, scoring_params.visited_count_buckets.half_life_days());
   ASSERT_EQ(2u, scoring_params.visited_count_buckets.buckets().size());
   EXPECT_EQ(std::make_pair(5.0, 300),
             scoring_params.visited_count_buckets.buckets()[0]);
   EXPECT_EQ(std::make_pair(0.0, 200),
             scoring_params.visited_count_buckets.buckets()[1]);
 }
 
+TEST_F(OmniboxFieldTrialTest, HUPNewScoringFieldTrialWithDecayFactor) {
+  {
+    std::map<std::string, std::string> params;
+    params[std::string(OmniboxFieldTrial::kHUPNewScoringEnabledParam)] = "1";

[Peter Kasting, 2015/08/27 19:21:40]

At least test locally whether std::string() can be omitted; I really would have
thought that the implicit string constructor would kick in here, but maybe the
fact that map is templated makes the compiler unable to figure this out.

[Ashok vardhan, 2015/08/27 19:51:38]

Its working on linux and can be omitted. I made the change. Thanks for that.!
Let me know if it doesn't work for other platforms.

[Peter Kasting, 2015/08/27 20:29:30]

The gold standard is "does it pass the trybots".  If it does, then bonus points
if you fix the similar instances elsewhere in this file.

+    params[std::string(
+        OmniboxFieldTrial::kHUPNewScoringTypedCountHalfLifeTimeParam)] = "10";
+    params[std::string(
+        OmniboxFieldTrial::kHUPNewScoringTypedCountUseDecayFactorParam)] = "1";
+    params[std::string(
+        OmniboxFieldTrial::kHUPNewScoringTypedCountScoreBucketsParam)] =
+        "0.1:100,0.5:500,1.0:1000";
+    ASSERT_TRUE(variations::AssociateVariationParams(
+        OmniboxFieldTrial::kBundledExperimentFieldTrialName, "A", params));
+  }
+  base::FieldTrialList::CreateFieldTrial(
+      OmniboxFieldTrial::kBundledExperimentFieldTrialName, "A");
+
+  HUPScoringParams scoring_params;
+  OmniboxFieldTrial::GetExperimentalHUPScoringParams(&scoring_params);
+  EXPECT_TRUE(scoring_params.experimental_scoring_enabled);
+  EXPECT_EQ(10, scoring_params.typed_count_buckets.half_life_days());
+  ASSERT_EQ(3u, scoring_params.typed_count_buckets.buckets().size());
+  ASSERT_EQ(true, scoring_params.typed_count_buckets.use_decay_factor());

[Bart N., 2015/08/27 19:22:33]

ASSERT_TRUE instead?

[Ashok vardhan, 2015/08/27 19:51:38]

Done.

+}
+
 TEST_F(OmniboxFieldTrialTest, HalfLifeTimeDecay) {
   HUPScoringParams::ScoreBuckets buckets;
 
   // No decay by default.
   EXPECT_EQ(1.0, buckets.HalfLifeTimeDecay(base::TimeDelta::FromDays(7)));
 
   buckets.set_half_life_days(7);
   EXPECT_EQ(0.5, buckets.HalfLifeTimeDecay(base::TimeDelta::FromDays(7)));
   EXPECT_EQ(0.25, buckets.HalfLifeTimeDecay(base::TimeDelta::FromDays(14)));
   EXPECT_EQ(1.0, buckets.HalfLifeTimeDecay(base::TimeDelta::FromDays(0)));
@@ skipping 32 matching lines @@
       NULL, NULL, false,
       OmniboxFieldTrial::kDefaultMinimumTimeBetweenSuggestQueriesMs);
 
   // Valid params.
   VerifySuggestPollingStrategy("true", "50", true, 50);
   VerifySuggestPollingStrategy(NULL, "35", false, 35);
   VerifySuggestPollingStrategy(
       "true", NULL, true,
       OmniboxFieldTrial::kDefaultMinimumTimeBetweenSuggestQueriesMs);
 }