Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Side by Side Diff: components/omnibox/browser/omnibox_field_trial_unittest.cc

Issue 1286093006: Launch HQP & HUP score changes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing Barts comments Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/omnibox/browser/omnibox_field_trial.h" 5 #include "components/omnibox/browser/omnibox_field_trial.h"
6 6
7 #include "base/basictypes.h" 7 #include "base/basictypes.h"
8 #include "base/command_line.h" 8 #include "base/command_line.h"
9 #include "base/memory/scoped_ptr.h" 9 #include "base/memory/scoped_ptr.h"
10 #include "base/metrics/field_trial.h" 10 #include "base/metrics/field_trial.h"
(...skipping 428 matching lines...) Expand 10 before | Expand all | Expand 10 after
439 scoring_params.typed_count_buckets.buckets()[2]); 439 scoring_params.typed_count_buckets.buckets()[2]);
440 EXPECT_EQ(11, scoring_params.visited_count_buckets.relevance_cap()); 440 EXPECT_EQ(11, scoring_params.visited_count_buckets.relevance_cap());
441 EXPECT_EQ(31, scoring_params.visited_count_buckets.half_life_days()); 441 EXPECT_EQ(31, scoring_params.visited_count_buckets.half_life_days());
442 ASSERT_EQ(2u, scoring_params.visited_count_buckets.buckets().size()); 442 ASSERT_EQ(2u, scoring_params.visited_count_buckets.buckets().size());
443 EXPECT_EQ(std::make_pair(5.0, 300), 443 EXPECT_EQ(std::make_pair(5.0, 300),
444 scoring_params.visited_count_buckets.buckets()[0]); 444 scoring_params.visited_count_buckets.buckets()[0]);
445 EXPECT_EQ(std::make_pair(0.0, 200), 445 EXPECT_EQ(std::make_pair(0.0, 200),
446 scoring_params.visited_count_buckets.buckets()[1]); 446 scoring_params.visited_count_buckets.buckets()[1]);
447 } 447 }
448 448
449 TEST_F(OmniboxFieldTrialTest, HUPNewScoringFieldTrialWithDecayFactor) {
450 {
451 std::map<std::string, std::string> params;
452 params[std::string(OmniboxFieldTrial::kHUPNewScoringEnabledParam)] = "1";
Peter Kasting 2015/08/27 00:50:45 Do the std::string() calls here need to be explici
Ashok vardhan 2015/08/27 19:09:27 I think so, to convert const char to string. Follo
453 params[std::string(
454 OmniboxFieldTrial::kHUPNewScoringTypedCountHalfLifeTimeParam)] = "10";
455 params[std::string(
456 OmniboxFieldTrial::kHUPNewScoringTypedCountUseDecayFactorParam)] = "1";
457 params[std::string(
458 OmniboxFieldTrial::kHUPNewScoringTypedCountScoreBucketsParam)] =
459 "0.1:100,0.5:500,1.0:1000";
460 ASSERT_TRUE(variations::AssociateVariationParams(
461 OmniboxFieldTrial::kBundledExperimentFieldTrialName, "A", params));
462 }
463 base::FieldTrialList::CreateFieldTrial(
464 OmniboxFieldTrial::kBundledExperimentFieldTrialName, "A");
465
466 HUPScoringParams scoring_params;
467 OmniboxFieldTrial::GetExperimentalHUPScoringParams(&scoring_params);
468 EXPECT_TRUE(scoring_params.experimental_scoring_enabled);
469 EXPECT_EQ(10, scoring_params.typed_count_buckets.half_life_days());
470 ASSERT_EQ(3u, scoring_params.typed_count_buckets.buckets().size());
471 ASSERT_EQ(true, scoring_params.typed_count_buckets.use_decay_factor());
472 }
473
449 TEST_F(OmniboxFieldTrialTest, HalfLifeTimeDecay) { 474 TEST_F(OmniboxFieldTrialTest, HalfLifeTimeDecay) {
450 HUPScoringParams::ScoreBuckets buckets; 475 HUPScoringParams::ScoreBuckets buckets;
451 476
452 // No decay by default. 477 // No decay by default.
453 EXPECT_EQ(1.0, buckets.HalfLifeTimeDecay(base::TimeDelta::FromDays(7))); 478 EXPECT_EQ(1.0, buckets.HalfLifeTimeDecay(base::TimeDelta::FromDays(7)));
454 479
455 buckets.set_half_life_days(7); 480 buckets.set_half_life_days(7);
456 EXPECT_EQ(0.5, buckets.HalfLifeTimeDecay(base::TimeDelta::FromDays(7))); 481 EXPECT_EQ(0.5, buckets.HalfLifeTimeDecay(base::TimeDelta::FromDays(7)));
457 EXPECT_EQ(0.25, buckets.HalfLifeTimeDecay(base::TimeDelta::FromDays(14))); 482 EXPECT_EQ(0.25, buckets.HalfLifeTimeDecay(base::TimeDelta::FromDays(14)));
458 EXPECT_EQ(1.0, buckets.HalfLifeTimeDecay(base::TimeDelta::FromDays(0))); 483 EXPECT_EQ(1.0, buckets.HalfLifeTimeDecay(base::TimeDelta::FromDays(0)));
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
491 NULL, NULL, false, 516 NULL, NULL, false,
492 OmniboxFieldTrial::kDefaultMinimumTimeBetweenSuggestQueriesMs); 517 OmniboxFieldTrial::kDefaultMinimumTimeBetweenSuggestQueriesMs);
493 518
494 // Valid params. 519 // Valid params.
495 VerifySuggestPollingStrategy("true", "50", true, 50); 520 VerifySuggestPollingStrategy("true", "50", true, 50);
496 VerifySuggestPollingStrategy(NULL, "35", false, 35); 521 VerifySuggestPollingStrategy(NULL, "35", false, 35);
497 VerifySuggestPollingStrategy( 522 VerifySuggestPollingStrategy(
498 "true", NULL, true, 523 "true", NULL, true,
499 OmniboxFieldTrial::kDefaultMinimumTimeBetweenSuggestQueriesMs); 524 OmniboxFieldTrial::kDefaultMinimumTimeBetweenSuggestQueriesMs);
500 } 525 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698