Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Unified Diff: runtime/vm/timeline_test.cc

Issue 1286093005: Fix MacOS build (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/os_thread_win.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/timeline_test.cc
diff --git a/runtime/vm/timeline_test.cc b/runtime/vm/timeline_test.cc
index a91ea6e4bc8b15dd558dd0cceb46e5cec41b16ef..69db5bf3c9c12153057846c5bf81cbc5dace5d48 100644
--- a/runtime/vm/timeline_test.cc
+++ b/runtime/vm/timeline_test.cc
@@ -24,7 +24,7 @@ class TimelineTestHelper : public AllStatic {
TimelineEvent* event = block->StartEvent();
ASSERT(event != NULL);
event->DurationBegin("fake");
- event->thread_ = static_cast<ThreadId>(ftid);
+ event->thread_ = OSThread::ThreadIdFromIntPtr(ftid);
return event;
}
};
@@ -280,10 +280,12 @@ TEST_CASE(TimelineAnalysis_ThreadBlockCount) {
EXPECT_EQ(2, ta.NumThreads());
// Extract both threads.
- TimelineAnalysisThread* thread_1 = ta.GetThread(static_cast<ThreadId>(1));
- TimelineAnalysisThread* thread_2 = ta.GetThread(static_cast<ThreadId>(2));
- EXPECT_EQ(static_cast<ThreadId>(1), thread_1->id());
- EXPECT_EQ(static_cast<ThreadId>(2), thread_2->id());
+ TimelineAnalysisThread* thread_1 =
+ ta.GetThread(OSThread::ThreadIdFromIntPtr(1));
+ TimelineAnalysisThread* thread_2 =
+ ta.GetThread(OSThread::ThreadIdFromIntPtr(2));
+ EXPECT_EQ(OSThread::ThreadIdFromIntPtr(1), thread_1->id());
+ EXPECT_EQ(OSThread::ThreadIdFromIntPtr(2), thread_2->id());
// Thread "1" should have three blocks.
EXPECT_EQ(3, thread_1->NumBlocks());
« no previous file with comments | « runtime/vm/os_thread_win.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698