content/browser/bluetooth/bluetooth_metrics.h - Issue 1286063002: Add a path for content/ to open and control a Bluetooth chooser dialog.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/bluetooth/bluetooth_metrics.h

Issue 1286063002: Add a path for content/ to open and control a Bluetooth chooser dialog. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkcr

Patch Set: Remove an unnecessary include and forward decl Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/bluetooth/bluetooth_dispatcher_host.cc ('K') | « content/browser/bluetooth/bluetooth_dispatcher_host.cc ('k') | content/browser/bluetooth/first_device_bluetooth_chooser.h » ('j') | content/public/browser/bluetooth_chooser.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/bluetooth/bluetooth_metrics.h

diff --git a/content/browser/bluetooth/bluetooth_metrics.h b/content/browser/bluetooth/bluetooth_metrics.h

index d0947650db532530c3083a61766056e39e150fc6..602eca8c250c1e55abf19d0f4af2dd2d55554b76 100644

--- a/content/browser/bluetooth/bluetooth_metrics.h

+++ b/content/browser/bluetooth/bluetooth_metrics.h

@@ -43,11 +43,14 @@ enum class UMARequestDeviceOutcome {

SUCCESS = 0,

NO_BLUETOOTH_ADAPTER = 1,

NO_RENDER_FRAME = 2,

- DISCOVERY_START_FAILED = 3,

- DISCOVERY_STOP_FAILED = 4,

- NO_MATCHING_DEVICES_FOUND = 5,

+ OBSOLETE_DISCOVERY_START_FAILED = 3,

+ OBSOLETE_DISCOVERY_STOP_FAILED = 4,

+ OBSOLETE_NO_MATCHING_DEVICES_FOUND = 5,

BLUETOOTH_ADAPTER_NOT_PRESENT = 6,

- BLUETOOTH_ADAPTER_OFF = 7,

+ OBSOLETE_BLUETOOTH_ADAPTER_OFF = 7,

+ NO_BLUETOOTH_CHOOSER_IMPLEMENTATION = 8,

+ CHOSEN_DEVICE_VANISHED = 9,

+ BLUETOOTH_CHOOSER_CANCELLED = 10,

// NOTE: Add new requestDevice() outcomes immediately above this line. Make

// sure to update the enum list in

// tools/metrics/histograms/histograms.xml accordingly.