Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 1286043005: Rebaseline table tests on Yosemite (Closed)

Created:
5 years, 4 months ago by leviw_travelin_and_unemployed
Modified:
5 years, 4 months ago
Reviewers:
joelo
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Rebaseline table tests on Yosemite I manually verified this giant pile of tests are okay. Mostly, the results change from blending border colors at the corners and from a skia change to how images are scaled. Those changes happened during the dark times when the 10.10 bot wasn't processing rebaselines. BUG=508724, 509025 TBR=joelo Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200859

Patch Set 1 #

Patch Set 2 : ToTed #

Patch Set 3 : Include new results #

Unified diffs Side-by-side diffs Delta from patch set Stats (+573 lines, -573 lines) Patch
M LayoutTests/TestExpectations View 1 2 1 chunk +573 lines, -573 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
leviw_travelin_and_unemployed
5 years, 4 months ago (2015-08-19 21:53:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1286043005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1286043005/1
5 years, 4 months ago (2015-08-19 21:53:57 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/58790) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 4 months ago (2015-08-19 21:55:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1286043005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1286043005/40001
5 years, 4 months ago (2015-08-19 22:28:03 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://src.chromium.org/viewvc/blink?view=rev&revision=200859
5 years, 4 months ago (2015-08-20 00:03:16 UTC) #8
joelo
5 years, 4 months ago (2015-08-20 20:06:12 UTC) #9
Message was sent while issue was closed.
lgtm

lgtm. thanks levi, u r awesome

Powered by Google App Engine
This is Rietveld 408576698