Add check to see if stack pointer is off the stack according to the memory

Add check to see if stack pointer is off the stack according to the memory
mappings when rating Linux exploitability.

R=ivanpe@chromium.org

Committed: https://code.google.com/p/google-breakpad/source/detail?r=1487

[liuandrew, 2015-08-12 00:08:29]

liu.andrew.x@gmail.com changed reviewers:
+ ahonig@google.com, ivanpe@chromium.org

[ivanpe, 2015-08-12 00:31:59]

https://codereview.chromium.org/1286033002/diff/1/src/processor/exploitabilit...
File src/processor/exploitability_linux.cc (right):

https://codereview.chromium.org/1286033002/diff/1/src/processor/exploitabilit...
src/processor/exploitability_linux.cc:136: bool
ExploitabilityLinux::StackPointerOffStack(uint64_t stack_ptr) {
Please, consider adding a unittest for this method.

https://codereview.chromium.org/1286033002/diff/1/src/processor/exploitabilit...
src/processor/exploitability_linux.cc:139: if (linux_maps_list == NULL) {
Please, be consistent when checking for NULL.  I think, in this project we use:

if (!linux_maps_list) {

https://codereview.chromium.org/1286033002/diff/1/src/processor/exploitabilit...
File src/processor/exploitability_linux.h (right):

https://codereview.chromium.org/1286033002/diff/1/src/processor/exploitabilit...
src/processor/exploitability_linux.h:62: bool StackPointerOffStack(uint64_t
stack_ptr);
Please, add methid description.

[liuandrew, 2015-08-14 22:43:17]

Uploaded patch set 2.

Changes include:
 - unittests
 - other miscellanous changes

https://codereview.chromium.org/1286033002/diff/1/src/processor/exploitabilit...
File src/processor/exploitability_linux.cc (right):

https://codereview.chromium.org/1286033002/diff/1/src/processor/exploitabilit...
src/processor/exploitability_linux.cc:136: bool
ExploitabilityLinux::StackPointerOffStack(uint64_t stack_ptr) {
On 2015/08/12 00:31:59, ivanpe wrote:
> Please, consider adding a unittest for this method.

Done.

https://codereview.chromium.org/1286033002/diff/1/src/processor/exploitabilit...
src/processor/exploitability_linux.cc:139: if (linux_maps_list == NULL) {
On 2015/08/12 00:31:59, ivanpe wrote:
> Please, be consistent when checking for NULL.  I think, in this project we
use:
> 
> if (!linux_maps_list) {

Done.

https://codereview.chromium.org/1286033002/diff/1/src/processor/exploitabilit...
File src/processor/exploitability_linux.h (right):

https://codereview.chromium.org/1286033002/diff/1/src/processor/exploitabilit...
src/processor/exploitability_linux.h:62: bool StackPointerOffStack(uint64_t
stack_ptr);
On 2015/08/12 00:31:59, ivanpe wrote:
> Please, add methid description.

Done.

[ivanpe, 2015-08-14 23:13:29]

lgtm

[liuandrew, 2015-08-15 00:27:34]

Committed patchset #2 (id:20001) manually as r1487 (presubmit successful).