Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(599)

Issue 1285973006: Thou shalt use override consistently. (Closed)

Created:
5 years, 4 months ago by mtklein_C
Modified:
5 years, 4 months ago
Reviewers:
herb_g
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M src/gpu/batches/GrDrawPathBatch.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/pdf/SkPDFFontImpl.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1285973006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1285973006/1
5 years, 4 months ago (2015-08-19 20:53:24 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/3a30cc1cbb2f42bcbd0695cb994a5f1a52754a89
5 years, 4 months ago (2015-08-19 21:01:46 UTC) #3
herb_g
5 years, 4 months ago (2015-08-19 21:34:42 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698