Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Issue 1285973003: Add asserts for shared mutex. (Closed)

Created:
5 years, 4 months ago by herb_g
Modified:
5 years, 4 months ago
Reviewers:
mtklein, mtklein_C
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add asserts for shared mutex. BUG=skia: Committed: https://skia.googlesource.com/skia/+/ab42ec79d5dbf38b81394c55670b495cdf78b243

Patch Set 1 #

Patch Set 2 : fix line size. #

Total comments: 2

Patch Set 3 : add SkDebug guards #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -0 lines) Patch
M src/core/SkSharedMutex.h View 1 2 1 chunk +15 lines, -0 lines 0 comments Download
M src/core/SkSharedMutex.cpp View 1 2 2 chunks +30 lines, -0 lines 0 comments Download
M tests/SkSharedMutexTest.cpp View 3 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (5 generated)
herb_g
5 years, 4 months ago (2015-08-19 18:35:29 UTC) #2
herb_g
5 years, 4 months ago (2015-08-19 18:37:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1285973003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1285973003/20001
5 years, 4 months ago (2015-08-19 18:37:47 UTC) #5
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 4 months ago (2015-08-19 18:37:48 UTC) #6
herb_g
5 years, 4 months ago (2015-08-19 18:38:38 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: Build-Mac10.8-Clang-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Mac10.8-Clang-x86_64-Release-Trybot/builds/5183)
5 years, 4 months ago (2015-08-19 18:40:09 UTC) #9
mtklein
https://codereview.chromium.org/1285973003/diff/20001/src/core/SkSharedMutex.h File src/core/SkSharedMutex.h (right): https://codereview.chromium.org/1285973003/diff/20001/src/core/SkSharedMutex.h#newcode32 src/core/SkSharedMutex.h:32: void assertHeld() const; Let's do something like this to ...
5 years, 4 months ago (2015-08-19 19:00:52 UTC) #10
herb_g
https://codereview.chromium.org/1285973003/diff/20001/src/core/SkSharedMutex.h File src/core/SkSharedMutex.h (right): https://codereview.chromium.org/1285973003/diff/20001/src/core/SkSharedMutex.h#newcode32 src/core/SkSharedMutex.h:32: void assertHeld() const; On 2015/08/19 19:00:51, mtklein wrote: > ...
5 years, 4 months ago (2015-08-19 20:30:50 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1285973003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1285973003/40001
5 years, 4 months ago (2015-08-19 20:31:12 UTC) #13
mtklein_C
lgtm
5 years, 4 months ago (2015-08-19 20:39:35 UTC) #15
commit-bot: I haz the power
5 years, 4 months ago (2015-08-19 20:40:16 UTC) #16
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/ab42ec79d5dbf38b81394c55670b495cdf78b243

Powered by Google App Engine
This is Rietveld 408576698