Switch devenv to use pkg packages

Switch devenv to use pkg packages

Remove all the old logic for generating pacakges
for devenv.

R=bradnelson@google.com

Committed: https://chromium.googlesource.com/external/naclports/+/81cf0f3047e5a52f2e3df89c354f68c4d286126b

[Sam Clegg, 2015-08-11 21:03:22]

sbc@chromium.org changed reviewers:
+ bradnelson@chromium.org, zhitingzhu@google.com

[Sam Clegg, 2015-08-11 21:03:22]

This change is probably not going to pass the bots just yet, but please take a
look now and see if it makes sense to you.

[Sam Clegg, 2015-08-18 00:59:17]

ptal

[Sam Clegg, 2015-08-18 01:31:14]

The CQ bit was checked by sbc@chromium.org

[Sam Clegg, 2015-08-18 01:31:22]

The CQ bit was unchecked by sbc@chromium.org

[Sam Clegg, 2015-08-18 01:31:26]

The CQ bit was checked by sbc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-08-18 01:31:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1285953002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1285953002/120001

[commit-bot: I haz the power, 2015-08-18 01:31:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-18 01:31:34]

No L-G-T-M from a valid reviewer yet. Only full committers are accepted.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[bradn, 2015-08-18 02:32:41]

bradnelson@google.com changed reviewers:
+ bradnelson@google.com

[bradn, 2015-08-18 02:32:41]

This ready for review?

[zhitingzhu, 2015-08-18 19:13:24]

https://codereview.chromium.org/1285953002/diff/140001/ports/devenv/package
File ports/devenv/package (right):

https://codereview.chromium.org/1285953002/diff/140001/ports/devenv/package#n...
ports/devenv/package:24: fi
Looks like this can be combined:

NACL_ARCH_ALT="${NACL_ARCH}"
PKG_ARCH="${NACL_ARCH}"
if [[ "${TOOLCHAIN}" == "pnacl" ]]; then
  NACL_ARCH_ALT="pnacl"
  PKG_ARCH="pnacl"
fi

[Sam Clegg, 2015-08-18 23:13:39]

https://codereview.chromium.org/1285953002/diff/140001/ports/devenv/package
File ports/devenv/package (right):

https://codereview.chromium.org/1285953002/diff/140001/ports/devenv/package#n...
ports/devenv/package:24: fi
On 2015/08/18 19:13:24, zhitingzhu wrote:
> Looks like this can be combined:
> 
> NACL_ARCH_ALT="${NACL_ARCH}"
> PKG_ARCH="${NACL_ARCH}"
> if [[ "${TOOLCHAIN}" == "pnacl" ]]; then
>   NACL_ARCH_ALT="pnacl"
>   PKG_ARCH="pnacl"
> fi

Removed.

[bradn, 2015-08-19 20:28:50]

Broadly lgtm

Is dropping the package bash script a later incremental goal?
Why not just call 'pkg install ${packages}' instead of going through that
script?

https://codereview.chromium.org/1285953002/diff/300001/ports/curl/nacl.patch
File ports/curl/nacl.patch (left):

https://codereview.chromium.org/1285953002/diff/300001/ports/curl/nacl.patch#...
ports/curl/nacl.patch:26: +#endif
Why can this go?

https://codereview.chromium.org/1285953002/diff/300001/ports/emacs/build.sh
File ports/emacs/build.sh (right):

https://codereview.chromium.org/1285953002/diff/300001/ports/emacs/build.sh#n...
ports/emacs/build.sh:50: # Today the install step copies emacs_x86_63.nexe to
the publish dir, but we
64

https://codereview.chromium.org/1285953002/diff/300001/ports/perl/build.sh
File ports/perl/build.sh (right):

https://codereview.chromium.org/1285953002/diff/300001/ports/perl/build.sh#ne...
ports/perl/build.sh:159: Makefile ${DESTDIR}${PREFIX}${LIB}
This seems odd? MakeDir ?

[Sam Clegg, 2015-08-19 21:31:11]

Yes, the existing package script is there for the transition period.

https://codereview.chromium.org/1285953002/diff/300001/ports/curl/nacl.patch
File ports/curl/nacl.patch (left):

https://codereview.chromium.org/1285953002/diff/300001/ports/curl/nacl.patch#...
ports/curl/nacl.patch:26: +#endif
On 2015/08/19 20:28:50, bradn wrote:
> Why can this go?

I'm defining this unconditionally on the cmdline now.

Before we have two version of curl, but now we only need a single binary for
sel_ldr and chrome.

https://codereview.chromium.org/1285953002/diff/300001/ports/emacs/build.sh
File ports/emacs/build.sh (right):

https://codereview.chromium.org/1285953002/diff/300001/ports/emacs/build.sh#n...
ports/emacs/build.sh:50: # Today the install step copies emacs_x86_63.nexe to
the publish dir, but we
On 2015/08/19 20:28:50, bradn wrote:
> 64

Done.

https://codereview.chromium.org/1285953002/diff/300001/ports/perl/build.sh
File ports/perl/build.sh (right):

https://codereview.chromium.org/1285953002/diff/300001/ports/perl/build.sh#ne...
ports/perl/build.sh:159: Makefile ${DESTDIR}${PREFIX}${LIB}
On 2015/08/19 20:28:50, bradn wrote:
> This seems odd? MakeDir ?

Done.

[Sam Clegg, 2015-08-19 21:31:16]

The CQ bit was checked by sbc@chromium.org

[Sam Clegg, 2015-08-19 21:31:16]

The patchset sent to the CQ was uploaded after l-g-t-m from
bradnelson@google.com
Link to the patchset: https://codereview.chromium.org/1285953002/#ps320001
(title: " ")

[commit-bot: I haz the power, 2015-08-19 21:31:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1285953002/320001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1285953002/320001

[commit-bot: I haz the power, 2015-08-20 00:01:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-20 00:01:03]

Try jobs failed on following builders:
  naclports-linux-clang-3 on tryserver.nacl (JOB_FAILED,
http://build.chromium.org/p/tryserver.nacl/builders/naclports-linux-clang-3/b...)
  naclports-linux-glibc-0 on tryserver.nacl (JOB_FAILED,
http://build.chromium.org/p/tryserver.nacl/builders/naclports-linux-glibc-0/b...)
  naclports-linux-glibc-3 on tryserver.nacl (JOB_FAILED,
http://build.chromium.org/p/tryserver.nacl/builders/naclports-linux-glibc-3/b...)
  naclports-linux-glibc-4 on tryserver.nacl (JOB_FAILED,
http://build.chromium.org/p/tryserver.nacl/builders/naclports-linux-glibc-4/b...)
  naclports-linux-newlib-0 on tryserver.nacl (JOB_FAILED,
http://build.chromium.org/p/tryserver.nacl/builders/naclports-linux-newlib-0/...)
  naclports-linux-newlib-3 on tryserver.nacl (JOB_FAILED,
http://build.chromium.org/p/tryserver.nacl/builders/naclports-linux-newlib-3/...)
  naclports-linux-pnacl-0 on tryserver.nacl (JOB_FAILED,
http://build.chromium.org/p/tryserver.nacl/builders/naclports-linux-pnacl-0/b...)
  naclports-linux-pnacl-4 on tryserver.nacl (JOB_FAILED,
http://build.chromium.org/p/tryserver.nacl/builders/naclports-linux-pnacl-4/b...)

[Sam Clegg, 2015-08-20 00:58:03]

The CQ bit was checked by sbc@chromium.org

[Sam Clegg, 2015-08-20 00:58:04]

The patchset sent to the CQ was uploaded after l-g-t-m from
bradnelson@google.com
Link to the patchset: https://codereview.chromium.org/1285953002/#ps340001
(title: " ")

[commit-bot: I haz the power, 2015-08-20 00:58:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1285953002/340001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1285953002/340001

[Sam Clegg, 2015-08-20 02:06:18]

Patchset #19 (id:350001) has been deleted

[Sam Clegg, 2015-08-20 16:42:35]

The CQ bit was checked by sbc@chromium.org

[Sam Clegg, 2015-08-20 16:42:36]

The patchset sent to the CQ was uploaded after l-g-t-m from
bradnelson@google.com
Link to the patchset: https://codereview.chromium.org/1285953002/#ps410001
(title: " ")

[commit-bot: I haz the power, 2015-08-20 16:42:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1285953002/410001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1285953002/410001

[commit-bot: I haz the power, 2015-08-20 19:36:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-20 19:36:47]

Try jobs failed on following builders:
  naclports-linux-clang-4 on tryserver.nacl (JOB_FAILED,
http://build.chromium.org/p/tryserver.nacl/builders/naclports-linux-clang-4/b...)

[Sam Clegg, 2015-08-20 21:25:05]

The CQ bit was checked by sbc@chromium.org

[Sam Clegg, 2015-08-20 21:25:05]

The patchset sent to the CQ was uploaded after l-g-t-m from
bradnelson@google.com
Link to the patchset: https://codereview.chromium.org/1285953002/#ps430001
(title: " ")

[commit-bot: I haz the power, 2015-08-20 21:25:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1285953002/430001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1285953002/430001

[Sam Clegg, 2015-08-20 21:27:20]

Committed patchset #22 (id:430001) manually as
81cf0f3047e5a52f2e3df89c354f68c4d286126b (presubmit successful).