runtime/vm/atomic.h - Issue 1285923003: Use memcpy for Atomic::LoadRelaxed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/atomic.h

Issue 1285923003: Use memcpy for Atomic::LoadRelaxed. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/atomic.h

diff --git a/runtime/vm/atomic.h b/runtime/vm/atomic.h

index 6197f16ab7b7a2ad3669bd37d18a5e63d8122ba6..769aad67ae4106596dcac56018bc3282cbd7d78c 100644

--- a/runtime/vm/atomic.h

+++ b/runtime/vm/atomic.h

@@ -25,7 +25,11 @@ class AtomicOperations : public AllStatic {

static uword CompareAndSwapWord(uword* ptr, uword old_value, uword new_value);

- static uword LoadRelaxed(uword* ptr);

+ static uword LoadRelaxed(uword* ptr) {

+ uword result;

+ memcpy(&result, ptr, sizeof(result));

+ return result;

+ }

};

« no previous file with comments | « no previous file | runtime/vm/atomic_android.h » ('j') | no next file with comments »